Skip to content

many: allow configuration of weak dependency installation in installer environments (HMS-9964)#2091

Merged
supakeen merged 2 commits intoosbuild:mainfrom
supakeen:installer-weak-deps
Jan 6, 2026
Merged

many: allow configuration of weak dependency installation in installer environments (HMS-9964)#2091
supakeen merged 2 commits intoosbuild:mainfrom
supakeen:installer-weak-deps

Conversation

@supakeen
Copy link
Member

@supakeen supakeen commented Dec 15, 2025

This PR brings our everything-network-installer size difference from ~200 MiB to just 36 MiB. 16 of which is probably due to packages that have grown post-release, and 20 of it is that we leave efiboot.img lying around in the ISO. The last one I also plan to address.

many: install weak dependencies in installers

By default we always installed weak dependencies in installers that use
the Anaconda tree for their environment. This makes this configurable
in the installer configuration in YAML.

This is because I noticed that we can drop the installation of weak
dependencies in Fedora's network installer (at a minimum).
fedora: no weak deps on network installer

Drop the weak dependency installation on the network installer for
Fedora. This brings the filesize within 36 MiB to the currently
Lorax-produced media. Previously the difference was ~200 MiB.

The last bits will need to be addressed separately but this is already
much more manageable.

@supakeen supakeen requested a review from a team as a code owner December 15, 2025 14:14
@supakeen supakeen changed the title Installer weak deps many: allow configuration of weak dependency installation in installer environments Dec 15, 2025
@supakeen supakeen force-pushed the installer-weak-deps branch 2 times, most recently from 76e9580 to 3039c62 Compare December 16, 2025 07:04
@supakeen
Copy link
Member Author

Had to force push since there were conflicts due to the syslinux PR #2089.

thozza
thozza previously approved these changes Dec 16, 2025
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

achilleas-k
achilleas-k previously approved these changes Dec 16, 2025
@achilleas-k achilleas-k added this pull request to the merge queue Dec 16, 2025
@supakeen supakeen removed this pull request from the merge queue due to a manual request Dec 16, 2025
@supakeen supakeen added this pull request to the merge queue Dec 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 16, 2025
@supakeen supakeen dismissed stale reviews from achilleas-k and thozza via 9c4c4bf December 16, 2025 20:30
@supakeen supakeen force-pushed the installer-weak-deps branch from 3039c62 to 9c4c4bf Compare December 16, 2025 20:30
@supakeen
Copy link
Member Author

@achilleas-k @thozza had to force push again since there were conflicts in checksums again.

thozza
thozza previously approved these changes Dec 17, 2025
@supakeen supakeen requested a review from lzap December 17, 2025 12:25
lzap
lzap previously approved these changes Dec 18, 2025
Copy link
Contributor

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah conflicts again.

@supakeen supakeen dismissed stale reviews from lzap and thozza via c1a0db1 December 18, 2025 17:48
@supakeen supakeen force-pushed the installer-weak-deps branch from 9c4c4bf to c1a0db1 Compare December 18, 2025 17:48
@supakeen supakeen requested review from lzap and thozza December 18, 2025 17:49
@supakeen
Copy link
Member Author

Ah conflicts again.

Yea, I've rebased again and fixed up the checksums.

@supakeen
Copy link
Member Author

With the latest rebase it seems there are many real failures in the CI that are unrelated to artifacts touched by this PR.

I see CentOS qcow's failing on finding a disk in initramfs, and I see pxe-tar-xz failures in the 'disk.img is not in qcow2' format? @achilleas-k / @lzap just for your awareness.

@lzap
Copy link
Contributor

lzap commented Dec 19, 2025

Looking into qemu2 image format first: #2103

Not sure about that initramfs problem yet.

I also see many FIPS failures as well.

@supakeen supakeen changed the title many: allow configuration of weak dependency installation in installer environments many: allow configuration of weak dependency installation in installer environments (HMS-9964) Jan 5, 2026
@supakeen supakeen force-pushed the installer-weak-deps branch from c1a0db1 to ec5d2ed Compare January 6, 2026 09:21
@supakeen supakeen requested review from croissanne and ondrejbudai and removed request for mvo5 January 6, 2026 11:45
By default we always installed weak dependencies in installers that use
the Anaconda tree for their environment. This makes this configurable
in the installer configuration in YAML.

This is because I noticed that we can drop the installation of weak
dependencies in Fedora's network installer (at a minimum).

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Drop the weak dependency installation on the network installer for
Fedora. This brings the filesize within 36 MiB to the currently
Lorax-produced media. Previously the difference was ~200 MiB.

The last bits will need to be addressed separately but this is already
much more manageable.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
@supakeen supakeen force-pushed the installer-weak-deps branch from ec5d2ed to c3f6637 Compare January 6, 2026 11:45
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slim!

Copy link
Contributor

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish this was my weight over holidays...

@supakeen supakeen added this pull request to the merge queue Jan 6, 2026
Merged via the queue into osbuild:main with commit c1201e5 Jan 6, 2026
25 checks passed
@supakeen supakeen deleted the installer-weak-deps branch January 6, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants