osbuild/osbuild-exec: extract building the osbuild cmd to helper #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croissanne
force-pushed
the
osbuild-exec-rework
branch
from
9592c5e to
0b36e7e
Compare
Contributor
|
This PR changes the images API or behaviour causing integration failures with osbuild-composer. The next update of the images dependency in osbuild-composer will need work to adapt to these changes. This is simply a notice. It will not block this PR from being merged. |
croissanne
force-pushed
the
osbuild-exec-rework
branch
from
0b36e7e to
9e9b2f3
Compare
croissanne
force-pushed
the
osbuild-exec-rework
branch
2 times, most recently
from
42f6f71 to
cbdd1b7
Compare
achilleas-k
approved these changes
Oct 21, 2025
Member
achilleas-k
left a comment
achilleas-k
left a comment
There was a problem hiding this comment.
Very good. LGTM.
But the commit message says images when it should say image-builder-cli.
`NewOSBuildCmd` takes inspiration from image-builder-cli[1], allowing consumers to manipulate the exec.Cmd as they see fit. This is useful for asynchronous invocations, `io.MultiWriter`s and use with `StatusScanner`s. [1] https://github.com/osbuild/image-builder-cli/blob/e348fc2542c6f09e969b021de7ac20e96840895e/pkg/progress/command.go#L51-L69
croissanne
force-pushed
the
osbuild-exec-rework
branch
from
cbdd1b7 to
1b53121
Compare
supakeen
approved these changes
Oct 21, 2025
croissanne
added a commit
to croissanne/osbuild-composer
that referenced
this pull request
Oct 22, 2025
In adapting to the new osbuild/osbuild-exec code, ExportPaths got dropped. This variable / option was not used anywhere anyway. Changes with 0.209.0 ---------------- - gitlab: run ostree manifest generation and builds only when needed (osbuild/images#1961) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - osbuild/osbuild-exec: extract building the osbuild cmd to helper (osbuild/images#1963) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Simon de Vlieger - rhel10: add ism secret & top secret oscap profiles (HMS-9507) (osbuild/images#1962) - Author: Gianluca Zuccarelli, Reviewers: Lukáš Zapletal, Sanne Raymaekers
croissanne
added a commit
to croissanne/image-builder-cli
that referenced
this pull request
Oct 22, 2025
Changes with 0.207.0 ---------------- - Enable fedora 43 unit testing (osbuild/images#1954) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - fedora: update cloud_kernel_options (osbuild/images#1953) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Simon de Vlieger - test/data/repos/rhel-10.2: fix copy & paste error (osbuild/images#1956) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Simon de Vlieger Changes with 0.208.0 ---------------- - Schutzfile: switch CI runner to Fedora 42 (osbuild/images#1955) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - Support uploading to IBM Cloud (osbuild/images#1924) - Author: Jakub Kadlčík, Reviewers: Achilleas Koutsou, Simon de Vlieger - pkg/osbuild: generate osbuild result from status scanner entries (osbuild/images#1941) - Author: Sanne Raymaekers, Reviewers: Nobody Changes with 0.209.0 ---------------- - gitlab: run ostree manifest generation and builds only when needed (osbuild/images#1961) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - osbuild/osbuild-exec: extract building the osbuild cmd to helper (osbuild/images#1963) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Simon de Vlieger - rhel10: add ism secret & top secret oscap profiles (HMS-9507) (osbuild/images#1962) - Author: Gianluca Zuccarelli, Reviewers: Lukáš Zapletal, Sanne Raymaekers
croissanne
added a commit
to osbuild/osbuild-composer
that referenced
this pull request
Oct 22, 2025
In adapting to the new osbuild/osbuild-exec code, ExportPaths got dropped. This variable / option was not used anywhere anyway. Changes with 0.209.0 ---------------- - gitlab: run ostree manifest generation and builds only when needed (osbuild/images#1961) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - osbuild/osbuild-exec: extract building the osbuild cmd to helper (osbuild/images#1963) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Simon de Vlieger - rhel10: add ism secret & top secret oscap profiles (HMS-9507) (osbuild/images#1962) - Author: Gianluca Zuccarelli, Reviewers: Lukáš Zapletal, Sanne Raymaekers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewOSBuildCmdtakes inspiration from images[1], allowing consumers to manipulate the exec.Cmd as they see fit. This is useful for asynchronous invocations,io.MultiWriters and use withStatusScanners.[1] https://github.com/osbuild/image-builder-cli/blob/e348fc2542c6f09e969b021de7ac20e96840895e/pkg/progress/command.go#L51-L69
TODO: