Support uploading to OpenStack by FrostyX · Pull Request #1921 · osbuild/images

FrostyX · 2025-10-02T21:55:59Z

In Copr, we upload our builder images to OSUOSL OpenStack using the glance image-create command. I think it would be really cool if we could use image-builder upload instead.

See osbuild/images#1921

GoryMoon

I just had a quick look and noticed some things that I have questions about

GoryMoon · 2025-10-04T22:57:23Z

go.mod

 	github.com/gobwas/glob v0.2.3
 	github.com/google/go-cmp v0.7.0
 	github.com/google/uuid v1.6.0
+	github.com/gophercloud/gophercloud v1.14.1


I noticed you are using a v1 legacy version of gophercloud (last version was over a year ago) rather than the current stable v2 version.
Is there a specific reason, or just missed that there is a more current version?

If there is no specific reason, here is a migration guide to v2 to help update: https://github.com/gophercloud/gophercloud/blob/main/docs/MIGRATING.md

Thank you for noticing. There wasn't any specific reason, just my mistake. I will update the code to use v2

GoryMoon · 2025-10-04T23:19:26Z

pkg/cloud/openstack/openstack.go

+	// This is needed otherwise we get the following error when authenticating:
+	//	   You must provide exactly one of DomainID or DomainName to
+	//	   authenticate by Username
+	// Even with an RC file that works perfectly fine with `openstack token issue`


This seems to be related to this issue: gophercloud/gophercloud#3440
TL;DR It currently only uses the OS_DOMAIN_NAME env instead of OS_PROJECT_DOMAIN_NAME and OS_USER_DOMAIN_NAME env variables.

I linked the issue from within the code comment.

GoryMoon · 2025-10-04T23:34:48Z

pkg/cloud/openstack/openstack.go

+		return fmt.Errorf("Failed to authenticate to OpenStack: %w", err)
+	}
+
+	client, err := ostack.NewImageServiceV2(provider, gophercloud.EndpointOpts{})


I'm not familiar with OpenStack, but from looking at some RC examples it can contain a region. It might be good to include the functionality here as well.
The example on gophercloud has the following code:

openstack.NewImageV2(ctx, providerClient, gophercloud.EndpointOpts{ Region: os.Getenv("OS_REGION_NAME"), })

GoryMoon · 2025-10-04T23:43:50Z

pkg/cloud/openstack/openstack.go

@@ -0,0 +1,89 @@
+//go:build cgo


This build constraint will make this feature only available with cgo; I don't think gophercloud requires that, so it's unnecessary here.

I took the libvirt.go as a template and forgot to remove this like. Good catch, thank you.

mvo5

Thank you! Looks good, tiny nitpicks/suggestions inline. Fixing the cgo thing would be great too.

mvo5 · 2025-10-06T14:19:08Z

pkg/cloud/openstack/openstack.go

+}
+
+func (ou *openstackUploader) Check(status io.Writer) error {
+	return nil


Might be nice to do some of the checks we do in UploadAndRegister here already. Not a blocker though.

To be honest, I am confused about the purpose of the Check method. My expectation was that if the check fails, we don't even try to upload. Which doesn't seem to be true. I return errors from my Check and UploadAndRegister gets called anyway.

Thanks, interesting. Then I must misremember how this works, its fine for now, we can always refactor it. The idea was that we would run "Check()" before we do an expensive upload and then discover that some permissions to move the image into the right place are missing (iirc that can happen on AWS). But if you say its not working for you we will investigate. Its easy enough to move some of the checks here in a followup.

I agree, adding the checks later should be easy. Check this out.

func (ou *openstackUploader) Check(status io.Writer) error { return errors.New("FAILED UPLOAD") }

The upload starts happening

[jkadlcik@hive image-builder]$ ./image-builder upload --to openstack ~/git/copr-image-builder/output/image/disk.raw --arch x86_64 --openstack-image frostyx_copr_hv_x86_64_01_prod_06740723_20250913_1418098 Uploading to OpenStack... 0 B / 10.00 GiB [________________________________________________________________________________________________________________________________________________________________________________________________________________] 0.00% ? p/s

And it's not a glitch because the "Uploading to OpenStack..." is there also. So we are definitely inside of the UploadAndRegister function.

mvo5 · 2025-10-06T14:20:22Z

pkg/cloud/openstack/openstack.go

+	//	   authenticate by Username
+	// Even with an RC file that works perfectly fine with `openstack token issue`
+	if opts.DomainName == "" {
+		opts.DomainName = os.Getenv("OS_USER_DOMAIN_NAME")


Should we double check that os.Getenv("OS_USER_DOMAIN_NAME") != "" ?

I don't think we should. If it is "" then it will fail with

error: Failed to authenticate to OpenStack: You must provide exactly one of DomainID or DomainName to authenticate by Username

which is not ideal but it is better than failing because it is empty even though the upload might maybe work without that? I am not sure what happens on other OpenStack instances.

But if you prefer to have the check, I can definitely add it.

In Copr, we upload our builder images to OSUOSL OpenStack using the `glance image-create` command. I think it would be really cool if we could use `image-builder upload` instead.

mvo5

Looks good

See osbuild/images#1921

Changes with 0.205.0 ---------------- - Convert the test config map to a config list (osbuild/images#1900) - Author: Achilleas Koutsou, Reviewers: Sanne Raymaekers, Simon de Vlieger - Repos: Add definitions for AlmaLinux 9.7, 9.8, 10.1 and 10.2 (osbuild/images#1926) - Author: Eduard Abdullin, Reviewers: Achilleas Koutsou, Brian C. Lane, Simon de Vlieger - Support uploading to OpenStack (osbuild/images#1921) - Author: Jakub Kadlčík, Reviewers: Michael Vogt, Simon de Vlieger - disk: make addPartitionsForBootMode() arch specific (osbuild/images#1928) - Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger - distro: add ova image type for bootc [HMS-9503] (osbuild/images#1938) - Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger - fedora/minimal: drop uuids in partition tables (osbuild/images#1932) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Michael Vogt Changes with 0.206.0 ---------------- - Update osbuild dependency commit ID to latest (osbuild/images#1945) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger - deps: bump blueprint to 1.16.0 (osbuild/images#1952) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Sanne Raymaekers - fedora: Drop tigervnc on F42 and later (osbuild/images#1942) - Author: Brian C. Lane, Reviewers: Simon de Vlieger, Tomáš Hozza - fedora: document root kickstart (osbuild/images#1936) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Michael Vogt - fedora: rawhide is 44 (osbuild/images#1943) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Tomáš Hozza - many: lorax template split (HMS-9524) (osbuild/images#1949) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Tomáš Hozza Changes with 0.207.0 ---------------- - Enable fedora 43 unit testing (osbuild/images#1954) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - fedora: update cloud_kernel_options (osbuild/images#1953) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Simon de Vlieger - test/data/repos/rhel-10.2: fix copy & paste error (osbuild/images#1956) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Simon de Vlieger Changes with 0.208.0 ---------------- - Schutzfile: switch CI runner to Fedora 42 (osbuild/images#1955) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - Support uploading to IBM Cloud (osbuild/images#1924) - Author: Jakub Kadlčík, Reviewers: Achilleas Koutsou, Simon de Vlieger - pkg/osbuild: generate osbuild result from status scanner entries (osbuild/images#1941) - Author: Sanne Raymaekers, Reviewers: Nobody

See osbuild/images#1921

FrostyX requested a review from a team as a code owner October 2, 2025 21:56

FrostyX requested review from achilleas-k, croissanne and mvo5 October 2, 2025 21:56

FrostyX added a commit to FrostyX/image-builder-cli that referenced this pull request Oct 2, 2025

Support uploading to OpenStack

396bc79

See osbuild/images#1921

FrostyX mentioned this pull request Oct 2, 2025

Support uploading to OpenStack osbuild/image-builder-cli#337

Merged

GoryMoon reviewed Oct 5, 2025

View reviewed changes

mvo5 reviewed Oct 6, 2025

View reviewed changes

Support uploading to OpenStack

d4c95df

In Copr, we upload our builder images to OSUOSL OpenStack using the `glance image-create` command. I think it would be really cool if we could use `image-builder upload` instead.

FrostyX force-pushed the openstack branch from e2b6994 to d4c95df Compare October 9, 2025 13:13

mvo5 approved these changes Oct 10, 2025

View reviewed changes

supakeen approved these changes Oct 10, 2025

View reviewed changes

supakeen enabled auto-merge October 10, 2025 08:59

supakeen added this pull request to the merge queue Oct 10, 2025

Merged via the queue into osbuild:main with commit 636f775 Oct 10, 2025
23 checks passed

FrostyX added a commit to FrostyX/image-builder-cli that referenced this pull request Oct 14, 2025

Support uploading to OpenStack

8f88d0a

See osbuild/images#1921

FrostyX mentioned this pull request Oct 14, 2025

Support uploading to IBM Cloud #1924

Merged

FrostyX added a commit to FrostyX/image-builder-cli that referenced this pull request Oct 16, 2025

Support uploading to OpenStack

59d5b73

See osbuild/images#1921

FrostyX added a commit to FrostyX/image-builder-cli that referenced this pull request Oct 16, 2025

Support uploading to OpenStack

ec90952

See osbuild/images#1921

github-merge-queue bot pushed a commit to osbuild/image-builder-cli that referenced this pull request Oct 20, 2025

Support uploading to OpenStack

e348fc2

See osbuild/images#1921

croissanne mentioned this pull request Oct 21, 2025

go.mod: update osbuild/images to v0.208.0 osbuild/osbuild-composer#4898

Merged

mvo5 pushed a commit to mvo5/image-builder-cli that referenced this pull request Dec 8, 2025

Support uploading to OpenStack

1a6fc41

See osbuild/images#1921

Conversation

FrostyX commented Oct 2, 2025

Uh oh!

GoryMoon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mvo5 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mvo5 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants