Support setting the releasever dnf variable through the Blueprint customization [HMS-9368]
#1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
The linter and integration tests aren't very happy about the first commit. So this should be fine once the blueprint PR is merged and released. |
achilleas-k
force-pushed
the
blueprint/dnf-releasever
branch
5 times, most recently
from
7c02418 to
8cd6465
Compare
achilleas-k
force-pushed
the
blueprint/dnf-releasever
branch
from
8cd6465 to
a551234
Compare
lzap
previously approved these changes
Sep 30, 2025
achilleas-k
force-pushed
the
blueprint/dnf-releasever
branch
from
a551234 to
8178a2f
Compare
Member
Author
|
Clicked the rebase button. Cleared that Snyk failure. |
thozza
requested changes
Oct 1, 2025
Member
thozza
left a comment
thozza
left a comment
There was a problem hiding this comment.
I believe there's a bug in the ImageConfig code, and the unit tests could be enhanced to detect the issue.
Other than that, everything looks good. 👍
achilleas-k
force-pushed
the
blueprint/dnf-releasever
branch
2 times, most recently
from
70c7ef3 to
7a87380
Compare
supakeen
previously approved these changes
Oct 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
Manifest checksums have changed. |
Member
Author
|
Rebasing and fixing up. |
achilleas-k
force-pushed
the
blueprint/dnf-releasever
branch
from
7a87380 to
19c92c8
Compare
supakeen
previously approved these changes
Oct 9, 2025
thozza
requested changes
Oct 9, 2025
tag v1.14.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 1.14.0 ---------------- - customization: add firstboot (osbuild/blueprint#23) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová — Somewhere on the Internet, 2025-09-29 --- tag v1.15.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 1.15.0 ---------------- - blueprint: new customization: dnf (osbuild/blueprint#34) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza — Somewhere on the Internet, 2025-09-29 ---
The dnf variable name is `releasever` and it is more consistent with other user-facing use cases where it is treated as a single word. So let's treat it internally as a single word as well. This matches the new blueprint customization. Similarly, rename the struct field from SetReleaseVerVar to SetReleaseverVar to match.
Minor fix for the grammar of an internal error.
We currently have no use case for specifying multiple sets of configs for dnf_config. More importantly, there's no reason to have multiple org.osbuild.dnf.config stages in the same pipeline. The stage can handle multiple variables and a single set of global dnf config options, so a single stage should be able to cover all use cases. Make the dnf_config.options.config option in the image definitions a single item instead of an array and only support generating a single dnf config stage.
The dnf config options getter has a fail state when there is a conflict between different options that shouldn't be used together. Return an error from the function instead of panicking.
achilleas-k
force-pushed
the
blueprint/dnf-releasever
branch
from
19c92c8 to
db8708c
Compare
supakeen
previously approved these changes
Oct 9, 2025
Previously this was not supported because the dnf_config.options.variables can set a releasever which would conflict with the variable set by enabling dnf_config.set_releasever_var. However, it's trivial to check for a conflicting variable of the same name and make that the only error condition. The tests have been rewritten to test all combinations.
Add a helper function that either updates or appends new variables to the dnf config stage options.
When the blueprint dnf config customization enables the new set_releasever option, add it to the dnf.config variables stage option.
Enable the new customizations on all RHEL image types where it makes
sense. This includes any image type that supports writing files to the
OS tree, since the new option creates a file in /etc/{dnf,yum}/vars.
achilleas-k
force-pushed
the
blueprint/dnf-releasever
branch
from
db8708c to
18d2fdb
Compare
thozza
approved these changes
Oct 9, 2025
supakeen
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the new customizations (see osbuild/blueprint#34) on all RHEL image types where it makes sense. This includes any image type that supports writing files to the OS tree, since the new option creates a file in
/etc/{dnf,yum}/vars.Notes (and request for comments):
org.osbuild.dnf.configstage, because I think it's unnecessary.pkg/customizations/dnf/) and the blueprint only affects one option from the whole stage.DNFStageOptions.UpdateVar()turned out, but the nil case also makes it a bit awkward.Also related: HMS-9335