Skip to content

blueprint: new customization: dnf#34

Merged
thozza merged 1 commit intoosbuild:mainfrom
achilleas-k:new-customization/dnf
Sep 29, 2025
Merged

blueprint: new customization: dnf#34
thozza merged 1 commit intoosbuild:mainfrom
achilleas-k:new-customization/dnf

Conversation

@achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Sep 23, 2025

New dnf customization block that enables one option for now: set_releasever. The option is meant to set the releasever dnf variable to the value of the distro's release version, which ties a system to a specific update of RHEL. This prevents a system from being updated to a later minor RHEL release through dnf upgrade and is the mechanism for keeping systems on extended support releases (EUS and E4S).

The dnf customization block is created so that it might later be used for other variables (perhaps even arbitrary, user-defined variables). However, the releasever variable will be treated separately so that it can be a simple switch that sets the releasever value to the one for the image's distro dynamically.

The config key set_releasever was chosen over set_release_ver because the variable name is releasever and it is more consistent with other user-facing use cases where it is treated as a single word.

@achilleas-k achilleas-k requested a review from a team as a code owner September 23, 2025 16:46
@achilleas-k achilleas-k mentioned this pull request Sep 23, 2025
Merged
mvo5
mvo5 previously approved these changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@achilleas-k
Copy link
Member Author

achilleas-k commented Sep 24, 2025

The blueprint-schema counterpart puts the option one level down, into dnf.config.set_releasever. It might be a good idea to do the same here.

lzap
lzap previously approved these changes Sep 25, 2025
View reviewed changes
@lzap
Copy link
Contributor

lzap commented Sep 25, 2025

The blueprint-schema counterpart puts the option one level down, into dnf.config.set_releasever. It might be a good idea to do the same here.

Not against, merge at will or refactor.

@achilleas-k
Copy link
Member Author

achilleas-k commented Sep 25, 2025

The blueprint-schema counterpart puts the option one level down, into dnf.config.set_releasever. It might be a good idea to do the same here.

Not against, merge at will or refactor.

I'll change it.

@achilleas-k
Copy link
Member Author

achilleas-k commented Sep 25, 2025

Done!

@achilleas-k achilleas-k dismissed stale reviews from lzap and mvo5 via 4e4e5ed September 25, 2025 13:14
@achilleas-k achilleas-k requested review from lzap and mvo5 September 25, 2025 13:14
lzap
lzap previously approved these changes Sep 26, 2025
View reviewed changes
@lzap
Copy link
Contributor

lzap commented Sep 26, 2025

Ah a conflict!

@lzap
Copy link
Contributor

lzap commented Sep 26, 2025 •
edited
Loading

Damn I resolved it via github UI to test out how it works and it created a merge commit, sorry! Can you rebase and force push over my commit?

@achilleas-k
blueprint: new customization: dnf
d82ca21 
New dnf customization block that enables one option for now:
config.set_releasever.  The option is meant to set the releasever dnf
variable to the value of the distro's release version, which ties a
system to a specific update of RHEL.  This prevents a system from being
updated to a later minor RHEL release through `dnf upgrade` and is the
mechanism for keeping systems on extended support releases (EUS and
E4S).

The dnf customization block is created so that it might later be used
for other variables (perhaps even arbitrary, user-defined variables).
However, the releasever variable will be treated separately so that it
can be a simple switch that sets the `releasever` value to the one for
the image's distro dynamically.

The config key `set_releasever` was chosen over `set_release_ver`
because the variable name is `releasever` and it is more consistent with
other user-facing use cases where it is treated as a single word.
@achilleas-k
Copy link
Member Author

achilleas-k commented Sep 26, 2025

Damn I resolved it via github UI to test out how it works and it created a merge commit, sorry! Can you rebase and force push over my commit?

Fixed

lzap
lzap approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry. Let's get this merged.

@achilleas-k achilleas-k mentioned this pull request Sep 29, 2025
Merged
@thozza thozza added this pull request to the merge queue Sep 29, 2025
Merged via the queue into osbuild:main with commit 1d305e9 Sep 29, 2025
4 checks passed
@achilleas-k achilleas-k deleted the new-customization/dnf branch September 29, 2025 13:16
achilleas-k added a commit to achilleas-k/images that referenced this pull request Sep 29, 2025
@achilleas-k
go.mod: update osbuild/blueprint to v1.15.0
36eae6c 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
achilleas-k added a commit to achilleas-k/images that referenced this pull request Sep 29, 2025
@achilleas-k
go.mod: update osbuild/blueprint to v1.15.0
9b24f61 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
achilleas-k added a commit to achilleas-k/images that referenced this pull request Oct 1, 2025
@achilleas-k
go.mod: update osbuild/blueprint to v1.15.0
a699cd2 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
achilleas-k added a commit to achilleas-k/images that referenced this pull request Oct 1, 2025
@achilleas-k
go.mod: update osbuild/blueprint to v1.15.0
1267813 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
github-merge-queue bot pushed a commit to osbuild/images that referenced this pull request Oct 7, 2025
@achilleas-k @supakeen
go.mod: update osbuild/blueprint to v1.15.0
50cb315 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
github-merge-queue bot pushed a commit to osbuild/images that referenced this pull request Oct 9, 2025
@achilleas-k
go.mod: update osbuild/blueprint to v1.15.0
ceca364 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
achilleas-k added a commit to achilleas-k/images that referenced this pull request Oct 9, 2025
@achilleas-k
go.mod: update osbuild/blueprint to v1.15.0
f968021 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
achilleas-k added a commit to achilleas-k/images that referenced this pull request Oct 9, 2025
@achilleas-k
go.mod: update osbuild/blueprint to v1.15.0
63ba88f 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
github-merge-queue bot pushed a commit to osbuild/images that referenced this pull request Oct 9, 2025
@achilleas-k
go.mod: update osbuild/blueprint to v1.15.0
074cc6c 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
github-merge-queue bot pushed a commit to osbuild/images that referenced this pull request Oct 9, 2025
@achilleas-k @supakeen
go.mod: update osbuild/blueprint to v1.15.0
44507d7 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
mvo5 pushed a commit to mvo5/images that referenced this pull request Oct 10, 2025
@achilleas-k @mvo5
go.mod: update osbuild/blueprint to v1.15.0
e406fc7 
tag v1.14.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.14.0

----------------
  - customization: add firstboot (osbuild/blueprint#23)
    - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Katarína Sieklová

— Somewhere on the Internet, 2025-09-29

---

tag v1.15.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>

Changes with 1.15.0

----------------
  - blueprint: new customization: dnf (osbuild/blueprint#34)
    - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michael Vogt, Tomáš Hozza

— Somewhere on the Internet, 2025-09-29

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzap lzap lzap approved these changes

@thozza thozza thozza approved these changes

@croissanne croissanne Awaiting requested review from croissanne croissanne is a code owner automatically assigned from osbuild/osbuild-reviewers

+1 more reviewer

@mvo5 mvo5 mvo5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@achilleas-k @lzap @mvo5 @thozza