RHEL/Azure: drop obsolete WAAgentConfig keys [RHEL-93894] and remove loglevel kernel option [RHEL-102372] #1611

achilleas-k · 2025-06-24T12:37:26Z

distro/rhel{9,10}: Azure: drop obsolete WAAgentConfig keys

Provisioning.UseCloudInit and Provisioning.Enabled are not supported.

Both of these options were removed in v2.2.45 (Nov 2019) [1]. The
ticket requests removing them for RHEL 9.7 and 10.1 onwards. However,
there is no sense in keeping them for 9.6 and 10.0 since they have no
effect on the behaviour of the agent.

[1] https://github.com/Azure/WALinuxAgent/releases/tag/v2.2.45

RHEL-93894

Note: The RHEL issue also mentions removing ResourceDisk.Format=n. We're still trying to understand the impact of this change, so it's going to be split off into a separate ticket.

distro/rhel{9,10}: Azure 9.7+ & 10.1+: remove loglevel kernel option

We have a request to increase the kernel loglevel from 3 to 7 in the
current and future Azure marketplace images. We decided to make this
change only in future releases (9.7+ and 10.1+) of the Azure marketplace
images.

The default RHEL kernel log level is 7, so dropping this option has the
desired effect, and is preferable to setting it explicitly (we prefer
relying on defaults whenever possible).

RHEL-102372

bcl

Looks good to me

mvo5

Thank you!

achilleas-k · 2025-06-25T16:05:59Z

Had to rebase and redo the RHEL 10 image config with the new condition style from #1608

supakeen

Re-ack

achilleas-k · 2025-06-26T08:40:47Z

Rebased and resolved checksums conflict.

supakeen

Re-ack.

achilleas-k · 2025-06-26T13:54:47Z

Once more!

mvo5

Still love it!

supakeen

Re-ack.

I'm very slightly annoyed, do we really keep doing this? I've acked this PR 4 times now and now there's checksum conflicts again.

achilleas-k · 2025-06-26T20:08:00Z

Yeah it's getting silly

thozza · 2025-06-27T09:32:37Z

So there's conflict again 😢

Should we maybe split checksums into separate files per manifest? 🤔

thozza

The overall changes LGTM.

However, a4cf3b8 Says Remove the ResourceDisk.Format option in the WAAgentConfig, but it does not touch the optoin in WAAgentConfig at all...

achilleas-k · 2025-07-29T12:31:21Z

Reduced this PR to a single change. See original description above.

achilleas-k · 2025-07-29T15:26:31Z

I added another commit here that was going to be a separate PR, but would have caused conflicts in the manifest checksums.

Provisioning.UseCloudInit and Provisioning.Enabled are not supported. Both of these options were removed in v2.2.45 (Nov 2019) [1]. The ticket requests removing them for RHEL 9.7 and 10.1 onwards. However, there is no sense in keeping them for 9.6 and 10.0 since they have no effect on the behaviour of the agent. [1] https://github.com/Azure/WALinuxAgent/releases/tag/v2.2.45 RHEL-93894

We have a request to increase the kernel loglevel from 3 to 7 in the current and future Azure marketplace images. We decided to make this change only in future releases (9.7+ and 10.1+) of the Azure marketplace images. The default RHEL kernel log level is 7, so dropping this option has the desired effect, and is preferable to setting it explicitly (we prefer relying on defaults whenever possible). RHEL-102372

mvo5

Thank you!

tag v0.165.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.165.0 ---------------- * distro: move rhel9 into a generic distro (osbuild/images#1645) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * Revert "distro: drop `ImageType.BasePartitionTable()`" (osbuild/images#1691) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * Update dependencies 2025-07-20 (osbuild/images#1675) * Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger * defs: add missing `bootstrap_containers` (osbuild/images#1679) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * disk: handle adding `PReP` partition on PPC64/s390x (HMS-8884) (osbuild/images#1681) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * distro: bring per-distro checkOptions back (osbuild/images#1678) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * distro: cleanups in the pkg/distro/generic area (osbuild/images#1686) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * distro: move rhel8 into a generic distro (osbuild/images#1643) * Author: Michael Vogt, Reviewers: Nobody * distro: small followups for PR#1682 (osbuild/images#1689) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza * distro: unify transform/match into a single concept (osbuild/images#1682) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza * distros: de-duplicate runner build packages for centos10 (osbuild/images#1680) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * github: disable Go dep updates through dependabot (osbuild/images#1683) * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza * repos: include almalinux 9.6 (osbuild/images#1677) * Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza * rhel9: wsl distribution config (osbuild/images#1694) * Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers * test/manifests/all-customizations: don't embed local file via URI (osbuild/images#1684) * Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Brian C. Lane — Somewhere on the Internet, 2025-07-28 --- tag v0.166.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.166.0 ---------------- * customizations/subscription: conditionally enable semanage call (HMS-8866) (osbuild/images#1673) * Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Michael Vogt * distro/rhel-10: versionlock shim-x64 in the azure-cvm image (osbuild/images#1697) * Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger * manifestmock: move container/pkg/commit mocks into helper (osbuild/images#1700) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * rhel9: `vagrant-libvirt`, `vagrant-virtualbox` (osbuild/images#1693) * Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers * rhel{9,10}: centos WSL refinement (HMS-8922) (osbuild/images#1690) * Author: Simon de Vlieger, Reviewers: Ondřej Budai, Sanne Raymaekers, Tomáš Hozza — Somewhere on the Internet, 2025-07-29 --- tag v0.167.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.167.0 ---------------- * RHEL/Azure: drop obsolete WAAgentConfig keys [RHEL-93894] and remove loglevel kernel option [RHEL-102372] (osbuild/images#1611) * Author: Achilleas Koutsou, Reviewers: Michael Vogt, Ondřej Budai, Sanne Raymaekers * Update dependencies 2025-07-27 (osbuild/images#1699) * Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger * distro/rhel9: set default_kernel to kernel-uki-virt (osbuild/images#1704) * Author: Achilleas Koutsou, Reviewers: Ondřej Budai, Simon de Vlieger * distro: drop legacy loaders and update tests (osbuild/images#1687) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza * distro: fix issues with yaml distro definitions and enable yaml checks (osbuild/images#1702) * Author: Achilleas Koutsou, Reviewers: Michael Vogt, Ondřej Budai, Simon de Vlieger — Somewhere on the Internet, 2025-07-30 ---

tag v0.165.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.165.0 ---------------- * distro: move rhel9 into a generic distro (osbuild/images#1645) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * Revert "distro: drop `ImageType.BasePartitionTable()`" (osbuild/images#1691) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * Update dependencies 2025-07-20 (osbuild/images#1675) * Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger * defs: add missing `bootstrap_containers` (osbuild/images#1679) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * disk: handle adding `PReP` partition on PPC64/s390x (HMS-8884) (osbuild/images#1681) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * distro: bring per-distro checkOptions back (osbuild/images#1678) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * distro: cleanups in the pkg/distro/generic area (osbuild/images#1686) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * distro: move rhel8 into a generic distro (osbuild/images#1643) * Author: Michael Vogt, Reviewers: Nobody * distro: small followups for PR#1682 (osbuild/images#1689) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza * distro: unify transform/match into a single concept (osbuild/images#1682) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza * distros: de-duplicate runner build packages for centos10 (osbuild/images#1680) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * github: disable Go dep updates through dependabot (osbuild/images#1683) * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza * repos: include almalinux 9.6 (osbuild/images#1677) * Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza * rhel9: wsl distribution config (osbuild/images#1694) * Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers * test/manifests/all-customizations: don't embed local file via URI (osbuild/images#1684) * Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Brian C. Lane — Somewhere on the Internet, 2025-07-28 --- tag v0.166.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.166.0 ---------------- * customizations/subscription: conditionally enable semanage call (HMS-8866) (osbuild/images#1673) * Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Michael Vogt * distro/rhel-10: versionlock shim-x64 in the azure-cvm image (osbuild/images#1697) * Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger * manifestmock: move container/pkg/commit mocks into helper (osbuild/images#1700) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * rhel9: `vagrant-libvirt`, `vagrant-virtualbox` (osbuild/images#1693) * Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers * rhel{9,10}: centos WSL refinement (HMS-8922) (osbuild/images#1690) * Author: Simon de Vlieger, Reviewers: Ondřej Budai, Sanne Raymaekers, Tomáš Hozza — Somewhere on the Internet, 2025-07-29 --- tag v0.167.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.167.0 ---------------- * RHEL/Azure: drop obsolete WAAgentConfig keys [RHEL-93894] and remove loglevel kernel option [RHEL-102372] (osbuild/images#1611) * Author: Achilleas Koutsou, Reviewers: Michael Vogt, Ondřej Budai, Sanne Raymaekers * Update dependencies 2025-07-27 (osbuild/images#1699) * Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger * distro/rhel9: set default_kernel to kernel-uki-virt (osbuild/images#1704) * Author: Achilleas Koutsou, Reviewers: Ondřej Budai, Simon de Vlieger * distro: drop legacy loaders and update tests (osbuild/images#1687) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza * distro: fix issues with yaml distro definitions and enable yaml checks (osbuild/images#1702) * Author: Achilleas Koutsou, Reviewers: Michael Vogt, Ondřej Budai, Simon de Vlieger — Somewhere on the Internet, 2025-07-30 --- tag v0.168.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.168.0 ---------------- * distro: fix bug in variable substitution for static distros (osbuild/images#1710) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * rhel{9,10}: azure for non-RHEL (HMS-8949) (osbuild/images#1707) * Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Michael Vogt — Somewhere on the Internet, 2025-07-30 ---

achilleas-k requested a review from a team as a code owner June 24, 2025 12:37

achilleas-k requested review from mvo5, supakeen and thozza June 24, 2025 12:37

achilleas-k force-pushed the rhel/azure/tweaks branch from ef88c39 to 22c793f Compare June 24, 2025 15:30

bcl previously approved these changes Jun 24, 2025

View reviewed changes

mvo5 previously approved these changes Jun 25, 2025

View reviewed changes

supakeen previously approved these changes Jun 25, 2025

View reviewed changes

achilleas-k dismissed stale reviews from supakeen, mvo5, and bcl via 80bd1fc June 25, 2025 16:05

achilleas-k force-pushed the rhel/azure/tweaks branch from 22c793f to 80bd1fc Compare June 25, 2025 16:05

achilleas-k requested review from bcl, mvo5 and supakeen June 25, 2025 16:06

supakeen previously approved these changes Jun 25, 2025

View reviewed changes

achilleas-k dismissed supakeen’s stale review via 50349ff June 26, 2025 08:40

achilleas-k force-pushed the rhel/azure/tweaks branch from 80bd1fc to 50349ff Compare June 26, 2025 08:40

supakeen previously approved these changes Jun 26, 2025

View reviewed changes

achilleas-k dismissed supakeen’s stale review via 48706ea June 26, 2025 13:54

achilleas-k force-pushed the rhel/azure/tweaks branch from 50349ff to 48706ea Compare June 26, 2025 13:54

mvo5 previously approved these changes Jun 26, 2025

View reviewed changes

supakeen reviewed Jun 26, 2025

View reviewed changes

achilleas-k mentioned this pull request Jun 27, 2025

WIP: rhel: drop GRUB_TERMINAL option from Azure images #1509

Closed

thozza previously approved these changes Jun 27, 2025

View reviewed changes

achilleas-k requested review from mvo5, supakeen and thozza July 29, 2025 12:29

achilleas-k changed the title ~~RHEL/Azure: drop obsolete WAAgentConfig keys [RHEL-93894]~~ RHEL/Azure: drop obsolete WAAgentConfig keys [RHEL-93894] and remove loglevel kernel option [RHEL-102372] Jul 29, 2025

achilleas-k force-pushed the rhel/azure/tweaks branch from a7f1ac8 to 62b9f8b Compare July 29, 2025 15:27

ondrejbudai approved these changes Jul 29, 2025

View reviewed changes

croissanne approved these changes Jul 29, 2025

View reviewed changes

achilleas-k force-pushed the rhel/azure/tweaks branch from 62b9f8b to fc50f9c Compare July 29, 2025 15:36

ondrejbudai enabled auto-merge July 29, 2025 15:36

ondrejbudai previously approved these changes Jul 29, 2025

View reviewed changes

croissanne previously approved these changes Jul 29, 2025

View reviewed changes

achilleas-k added 2 commits July 29, 2025 18:16

achilleas-k dismissed stale reviews from croissanne and ondrejbudai via aea960f July 29, 2025 16:16

achilleas-k force-pushed the rhel/azure/tweaks branch from fc50f9c to aea960f Compare July 29, 2025 16:16

croissanne approved these changes Jul 29, 2025

View reviewed changes

achilleas-k requested a review from ondrejbudai July 29, 2025 17:28

mvo5 approved these changes Jul 30, 2025

View reviewed changes

ondrejbudai added this pull request to the merge queue Jul 30, 2025

Merged via the queue into osbuild:main with commit 1d0b1dd Jul 30, 2025
22 checks passed

achilleas-k deleted the rhel/azure/tweaks branch July 30, 2025 13:27

achilleas-k mentioned this pull request Jul 30, 2025

go.mod: update osbuild/images to v0.168.0 osbuild/osbuild-composer#4799

Merged

RHEL/Azure: drop obsolete WAAgentConfig keys [RHEL-93894] and remove loglevel kernel option [RHEL-102372] #1611

RHEL/Azure: drop obsolete WAAgentConfig keys [RHEL-93894] and remove loglevel kernel option [RHEL-102372] #1611

Uh oh!

Conversation

achilleas-k commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcl left a comment

Choose a reason for hiding this comment

Uh oh!

mvo5 left a comment

Choose a reason for hiding this comment

Uh oh!

achilleas-k commented Jun 25, 2025

Uh oh!

supakeen left a comment

Choose a reason for hiding this comment

Uh oh!

achilleas-k commented Jun 26, 2025

Uh oh!

supakeen left a comment

Choose a reason for hiding this comment

Uh oh!

achilleas-k commented Jun 26, 2025

Uh oh!

mvo5 left a comment

Choose a reason for hiding this comment

Uh oh!

supakeen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

achilleas-k commented Jun 26, 2025

Uh oh!

thozza commented Jun 27, 2025

Uh oh!

thozza left a comment

Choose a reason for hiding this comment

Uh oh!

achilleas-k commented Jul 29, 2025

Uh oh!

achilleas-k commented Jul 29, 2025

Uh oh!

mvo5 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

achilleas-k commented Jun 24, 2025 •

edited

Loading

supakeen left a comment •

edited

Loading