Generalise blueprint validation for Fedora image types (HMS-6871) #1216

achilleas-k · 2025-02-13T16:19:40Z

This PR introduces a general way for image types to declare a list of supported and required blueprint options and a validator that verifies a blueprint against them. In the YAML definitions, this looks like:

supported_blueprint_options:
  - "packages"
  - "customizations.user"

which means that the image type supports only packages and user customizations. The same format works for required customizations.
The only required customization we have is the installation_device for the simplified installers.

The validation check is made against the JSON tags of the structs, which makes a lot more sense now that we have external image definitions. The original version used the struct field names, which required knowing the names of the blueprint fields in the code.

The validators themselves are generic; they take a list of strings and a reflect.Value, so they could be reused for other structures (we should probably use them for things like ostree options as well).

In this PR, the new validator is only applied to Fedora.

This gist is a summary of the current (in main) validations that happen for each distribution, based on each distro's checkOptions() function: https://gist.github.com/achilleas-k/299e672077eef017a2797645838e5ab4

Planned follow-ups:

Add to RHEL distros.
Validate ImageOptions as well.
Consider inheriting / merging lists like we do for things like packages.
Documentation.

For docs, we can now produce a list or table of supported options for each image type.

Here is a table I generated with a quick hacky script for the current PR:

Image type	supported options	required options
server-vagrant-libvirt	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
server-vagrant-virtualbox	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
server-qcow2	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
server-ami	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
server-oci	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
server-openstack	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
server-vhd	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
server-vmdk	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
server-ova	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
iot-commit	distro, packages, modules, groups, minimal, customizations.directories, customizations.files, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel.name, customizations.locale, customizations.repositories, customizations.services, customizations.timezone
iot-container	distro, packages, modules, groups, minimal, customizations.directories, customizations.files, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel.name, customizations.locale, customizations.repositories, customizations.services, customizations.timezone
iot-raw-xz	distro, customizations.files, customizations.directories, customizations.disk, customizations.filesystem, customizations.fips, customizations.user, customizations.group, customizations.kernel.append, customizations.locale, customizations.services
iot-qcow2	distro, customizations.files, customizations.directories, customizations.disk, customizations.filesystem, customizations.fips, customizations.user, customizations.group, customizations.kernel.append, customizations.locale, customizations.services
iot-bootable-container	distro, packages, modules, groups, minimal
minimal-raw-xz	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
minimal-raw-zst	distro, packages, modules, groups, containers, minimal, customizations.cacerts, customizations.directories, customizations.disk, customizations.files, customizations.filesystem, customizations.fips, customizations.firewall, customizations.user, customizations.group, customizations.hostname, customizations.kernel, customizations.locale, customizations.openscap, customizations.repositories, customizations.rpm, customizations.services, customizations.timezone
anaconda	distro, customizations.installer, customizations.user, customizations.group, customizations.fips, customizations.timezone, customizations.locale
iot-installer	distro, customizations.installer, customizations.user, customizations.group, customizations.fips, customizations.timezone, customizations.locale
workstation-live-installer	customizations.installer
minimal-installer	distro, customizations.installer, customizations.user, customizations.group, customizations.fips, customizations.timezone, customizations.locale
container	distro, packages, modules, groups, minimal
wsl	distro, packages, modules, groups, minimal
iot-simplified-installer	distro, customizations.installation_device, customizations.fdo, customizations.ignition, customizations.kernel, customizations.user, customizations.group, customizations.fips	customizations.installation_device

Outdated description:
Year-old branch that I never finished. I remembered it today during a discussion with @supakeen, @mvo5, and @schuellerf. Opening as draft because I don't want it to disappear or forget about it again.

pkg/blueprint/customizations.go

github-actions · 2025-03-22T04:00:25Z

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

github-actions · 2025-04-22T04:09:37Z

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

github-actions · 2025-06-15T04:18:53Z

This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days.

github-actions · 2025-06-22T04:20:02Z

This PR was closed because it has been stalled for 30+7 days with no activity.

mvo5 · 2025-06-23T08:07:39Z

We will need to keep this open for reference as it will become relevant for the YAMLification and move to a "generic" distro everywhere.

lzap · 2025-06-24T11:52:26Z

For the record, I have a ticket: https://issues.redhat.com/browse/HMS-8676

pkg/distro/validator.go

We actually need to check options based on the "distro-like" distro major version. Between rhel8 and rhel9 it seems some customizations are enabled that did not work before so until we have a more declarative way (and more tests) for the options checking we move a step "back" and bring back a lot of duplicated code from the original options checks, i.e. I went back and collected original "checkOptions()" code from before they all got folded into the "generic" checkOptions() to ensure maximum compatibility with the old options checking. This will make rhel8: osbuild#1643 but especially rhel9: osbuild#1645 a lot easier. I expect most (all?) of the options.go file to go away when osbuild#1216 gets merged.

We actually need to check options based on the "distro-like" distro major version. Between rhel8 and rhel9 it seems some customizations are enabled that did not work before so until we have a more declarative way (and more tests) for the options checking we move a step "back" and bring back a lot of duplicated code from the original options checks, i.e. I went back and collected original "checkOptions()" code from before they all got folded into the "generic" checkOptions() to ensure maximum compatibility with the old options checking. This will make rhel8: #1643 but especially rhel9: #1645 a lot easier. I expect most (all?) of the options.go file to go away when #1216 gets merged.

All image types should support the name, version, and description fields of the blueprint.

Add a name, description, and version to all blueprints in test/configs/. Some unused configs have been deleted. The description is used to describe the purpose and sometimes origin of the test configuration.

Update the validateSupportedConfig() function to catch two error cases, one nonsensical and one unsupported: 1. if a supported config list defines that a key supports a child element, but the parent element is not a container, this does not make sense and should produce a useful error message. 2. if the config uses a container type that is not covered by the validator (e.g. a map), produce a useful error message.

This is similar to the change in the previous commit but for the required list. Update the validateRequiredConfig() function to catch two error cases, one nonsensical and one unsupported: 1. if a required config list defines that a key requires a child element, but the parent element is not a container, this does not make sense and should produce a useful error message. 2. if the config specifies it requires an element of an unsupported type (bool, int), produce a useful error.

Reverse the listed check in validateSupportedConfig() to avoid the extra indentation of the 'else' condition.

achilleas-k · 2025-08-26T12:46:18Z

Updated:

Rebased.
Fixed conflict.
Added customizations.sshkey to all supported lists that also include customizations.user.
Added customizations.partitioning_mode to all supported lists that also include customizations.filesystem.

supakeen

Thank you.

This is addressed.

mvo5 · 2025-08-26T14:02:03Z

Its nice, having this will help with #1786 - i.e. we can selectively allow kernel options for the installer types that currently do not support them even if the underlying code is all unified.

tag v0.179.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.179.0 ---------------- - linter: migrate linter config, upgrade linter, enable gomod linter (osbuild/images#1722) - Author: Lukáš Zapletal, Reviewers: Michael Vogt, Simon de Vlieger - manifest: fix comment for OSCustomizations.BaseModules (osbuild/images#1777) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-08-25 --- tag v0.180.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.180.0 ---------------- - Add the netinst image type to RHEL 8, 9, and 10 (osbuild/images#1773) - Author: Brian C. Lane, Reviewers: Michael Vogt, Simon de Vlieger - Basic support for aboot support in bootc-image-builder (osbuild/images#1782) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt, Simon de Vlieger - Generalise blueprint validation for Fedora image types (HMS-6871) (osbuild/images#1216) - Author: Achilleas Koutsou, Reviewers: Nobody - Update dependencies 2025-08-24 (osbuild/images#1784) - Author: SchutzBot, Reviewers: Lukáš Zapletal, Simon de Vlieger - Update snapshots to 20250825 (osbuild/images#1788) - Author: SchutzBot, Reviewers: Sanne Raymaekers, Simon de Vlieger - distro,image: drop `imgTypeCustomizations` (osbuild/images#1780) - Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger, Tomáš Hozza - distro/generic: implicitly support blueprint metadata fields (osbuild/images#1767) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - test/scripts: new quickcheck script for CI image builds (osbuild/images#1771) - Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-08-27 --- tag v0.181.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.181.0 ---------------- - azure: add support for booting a VM & azure boot tests (HMS-9168) (osbuild/images#1750) - Author: Sanne Raymaekers, Reviewers: Simon de Vlieger, Tomáš Hozza - chore: drop `otk` (osbuild/images#1791) - Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza - distro: add a bootc distro (HMS-9176) (osbuild/images#1736) - Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: add support for filesystem from default_fs_type (HMS-8844) (osbuild/images#1713) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza - distrodefs/fedora: add supported customizations for net installer (osbuild/images#1768) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - fedora: do not mark images as firstboot (HMS-9222) (osbuild/images#1799) - Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers - image: add platform/filename to image.New*() (osbuild/images#1790) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-08-28 --- tag v0.182.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.182.0 ---------------- - distro: ensure correct bootc image type Filename() output (osbuild/images#1800) - Author: Michael Vogt, Reviewers: Ondřej Budai, Simon de Vlieger - distro: fedora: Update Minimal for some missing packages (osbuild/images#1803) - Author: Peter Robinson, Reviewers: Achilleas Koutsou, Simon de Vlieger - image,manifest: move installer metadata into InstallerCustomiaztions (osbuild/images#1789) - Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger — Somewhere on the Internet, 2025-08-28 --- tag v0.183.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.183.0 ---------------- - github: avoid single person code owners (osbuild/images#1795) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - github: enable validate checksums on the merge queue (osbuild/images#1805) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - github: fix the validate checksums action on the merge queue (osbuild/images#1807) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger — Somewhere on the Internet, 2025-09-01 --- tag v0.184.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.184.0 ---------------- - Add repo definitions for RHEL-9.8 and RHEL-10.2 (HMS-9173) (osbuild/images#1812) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Sanne Raymaekers - Add support to set partition GPT attributes in yaml format (osbuild/images#1817) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt - Fix Azure grub menu visibility in serial console [RHEL-95423, RHEL-95418] (osbuild/images#1814) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza - Fix handling of root user in kickstart stage [RHEL-4644] (osbuild/images#1806) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza - Support raw payloads in yaml partition info (osbuild/images#1829) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt - Update dependencies 2025-08-31 (osbuild/images#1811) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Lukáš Zapletal - Update osbuild dependency commit ID to latest (osbuild/images#1810) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza - Update snapshots to 20250901 (osbuild/images#1815) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza - bootc: add support for /usr/lib/bootc-image-builder/disk.yaml (osbuild/images#1816) - Author: Michael Vogt, Reviewers: Alexander Larsson, Tomáš Hozza - distro: Fix build container use in bootc distro (osbuild/images#1822) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt - distro: add bootc riscv partition table (osbuild/images#1794) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza - github: change yaml comment indentation to please linter (osbuild/images#1824) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Sanne Raymaekers - github: disable unit tests on distros without osbuild rpms (osbuild/images#1818) - Author: Achilleas Koutsou, Reviewers: Sanne Raymaekers, Tomáš Hozza - github: remove matrix value from test names (osbuild/images#1808) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza - github: run yaml checks on all yaml files (osbuild/images#1819) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Sanne Raymaekers, Tomáš Hozza - github: use git status to verify checksum changes (osbuild/images#1826) - Author: Achilleas Koutsou, Reviewers: Sanne Raymaekers, Tomáš Hozza - osbuild: inspect wrapper (HMS-8973) (osbuild/images#1715) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal - test/data/manifest-checksums: add 10.2 and 9.8 (osbuild/images#1827) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Tomáš Hozza - test/scripts/boot-image: skip boot for non-x86_64 azure vhds (osbuild/images#1813) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Tomáš Hozza - test: ensure manifest from bib/images are identical (osbuild/images#1797) - Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza — Somewhere on the Internet, 2025-09-04 --- tag v0.185.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.185.0 ---------------- - distrodefs/fedora: support enabled_modules for image types with packages (osbuild/images#1831) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michal Gold, Sanne Raymaekers, Tomáš Hozza — Somewhere on the Internet, 2025-09-04 ---

tag v0.179.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.179.0 ---------------- - linter: migrate linter config, upgrade linter, enable gomod linter (osbuild/images#1722) - Author: Lukáš Zapletal, Reviewers: Michael Vogt, Simon de Vlieger - manifest: fix comment for OSCustomizations.BaseModules (osbuild/images#1777) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-08-25 --- tag v0.180.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.180.0 ---------------- - Add the netinst image type to RHEL 8, 9, and 10 (osbuild/images#1773) - Author: Brian C. Lane, Reviewers: Michael Vogt, Simon de Vlieger - Basic support for aboot support in bootc-image-builder (osbuild/images#1782) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt, Simon de Vlieger - Generalise blueprint validation for Fedora image types (HMS-6871) (osbuild/images#1216) - Author: Achilleas Koutsou, Reviewers: Nobody - Update dependencies 2025-08-24 (osbuild/images#1784) - Author: SchutzBot, Reviewers: Lukáš Zapletal, Simon de Vlieger - Update snapshots to 20250825 (osbuild/images#1788) - Author: SchutzBot, Reviewers: Sanne Raymaekers, Simon de Vlieger - distro,image: drop `imgTypeCustomizations` (osbuild/images#1780) - Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger, Tomáš Hozza - distro/generic: implicitly support blueprint metadata fields (osbuild/images#1767) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - test/scripts: new quickcheck script for CI image builds (osbuild/images#1771) - Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-08-27 --- tag v0.181.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.181.0 ---------------- - azure: add support for booting a VM & azure boot tests (HMS-9168) (osbuild/images#1750) - Author: Sanne Raymaekers, Reviewers: Simon de Vlieger, Tomáš Hozza - chore: drop `otk` (osbuild/images#1791) - Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza - distro: add a bootc distro (HMS-9176) (osbuild/images#1736) - Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: add support for filesystem from default_fs_type (HMS-8844) (osbuild/images#1713) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza - distrodefs/fedora: add supported customizations for net installer (osbuild/images#1768) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - fedora: do not mark images as firstboot (HMS-9222) (osbuild/images#1799) - Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers - image: add platform/filename to image.New*() (osbuild/images#1790) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-08-28 --- tag v0.182.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.182.0 ---------------- - distro: ensure correct bootc image type Filename() output (osbuild/images#1800) - Author: Michael Vogt, Reviewers: Ondřej Budai, Simon de Vlieger - distro: fedora: Update Minimal for some missing packages (osbuild/images#1803) - Author: Peter Robinson, Reviewers: Achilleas Koutsou, Simon de Vlieger - image,manifest: move installer metadata into InstallerCustomiaztions (osbuild/images#1789) - Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger — Somewhere on the Internet, 2025-08-28 --- tag v0.183.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.183.0 ---------------- - github: avoid single person code owners (osbuild/images#1795) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - github: enable validate checksums on the merge queue (osbuild/images#1805) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - github: fix the validate checksums action on the merge queue (osbuild/images#1807) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger — Somewhere on the Internet, 2025-09-01 --- tag v0.184.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.184.0 ---------------- - Add repo definitions for RHEL-9.8 and RHEL-10.2 (HMS-9173) (osbuild/images#1812) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Sanne Raymaekers - Add support to set partition GPT attributes in yaml format (osbuild/images#1817) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt - Fix Azure grub menu visibility in serial console [RHEL-95423, RHEL-95418] (osbuild/images#1814) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza - Fix handling of root user in kickstart stage [RHEL-4644] (osbuild/images#1806) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza - Support raw payloads in yaml partition info (osbuild/images#1829) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt - Update dependencies 2025-08-31 (osbuild/images#1811) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Lukáš Zapletal - Update osbuild dependency commit ID to latest (osbuild/images#1810) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza - Update snapshots to 20250901 (osbuild/images#1815) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza - bootc: add support for /usr/lib/bootc-image-builder/disk.yaml (osbuild/images#1816) - Author: Michael Vogt, Reviewers: Alexander Larsson, Tomáš Hozza - distro: Fix build container use in bootc distro (osbuild/images#1822) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt - distro: add bootc riscv partition table (osbuild/images#1794) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza - github: change yaml comment indentation to please linter (osbuild/images#1824) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Sanne Raymaekers - github: disable unit tests on distros without osbuild rpms (osbuild/images#1818) - Author: Achilleas Koutsou, Reviewers: Sanne Raymaekers, Tomáš Hozza - github: remove matrix value from test names (osbuild/images#1808) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza - github: run yaml checks on all yaml files (osbuild/images#1819) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Sanne Raymaekers, Tomáš Hozza - github: use git status to verify checksum changes (osbuild/images#1826) - Author: Achilleas Koutsou, Reviewers: Sanne Raymaekers, Tomáš Hozza - osbuild: inspect wrapper (HMS-8973) (osbuild/images#1715) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal - test/data/manifest-checksums: add 10.2 and 9.8 (osbuild/images#1827) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Tomáš Hozza - test/scripts/boot-image: skip boot for non-x86_64 azure vhds (osbuild/images#1813) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Tomáš Hozza - test: ensure manifest from bib/images are identical (osbuild/images#1797) - Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza — Somewhere on the Internet, 2025-09-04 --- tag v0.185.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.185.0 ---------------- - distrodefs/fedora: support enabled_modules for image types with packages (osbuild/images#1831) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michal Gold, Sanne Raymaekers, Tomáš Hozza — Somewhere on the Internet, 2025-09-04 --- tag v0.186.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.186.0 ---------------- - Fixes for blueprint option validation in Fedora [HMS-6871] (osbuild/images#1823) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza — Somewhere on the Internet, 2025-09-04 ---

tag v0.179.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.179.0 ---------------- - linter: migrate linter config, upgrade linter, enable gomod linter (osbuild/images#1722) - Author: Lukáš Zapletal, Reviewers: Michael Vogt, Simon de Vlieger - manifest: fix comment for OSCustomizations.BaseModules (osbuild/images#1777) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-08-25 --- tag v0.180.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.180.0 ---------------- - Add the netinst image type to RHEL 8, 9, and 10 (osbuild/images#1773) - Author: Brian C. Lane, Reviewers: Michael Vogt, Simon de Vlieger - Basic support for aboot support in bootc-image-builder (osbuild/images#1782) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt, Simon de Vlieger - Generalise blueprint validation for Fedora image types (HMS-6871) (osbuild/images#1216) - Author: Achilleas Koutsou, Reviewers: Nobody - Update dependencies 2025-08-24 (osbuild/images#1784) - Author: SchutzBot, Reviewers: Lukáš Zapletal, Simon de Vlieger - Update snapshots to 20250825 (osbuild/images#1788) - Author: SchutzBot, Reviewers: Sanne Raymaekers, Simon de Vlieger - distro,image: drop `imgTypeCustomizations` (osbuild/images#1780) - Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger, Tomáš Hozza - distro/generic: implicitly support blueprint metadata fields (osbuild/images#1767) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - test/scripts: new quickcheck script for CI image builds (osbuild/images#1771) - Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-08-27 --- tag v0.181.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.181.0 ---------------- - azure: add support for booting a VM & azure boot tests (HMS-9168) (osbuild/images#1750) - Author: Sanne Raymaekers, Reviewers: Simon de Vlieger, Tomáš Hozza - chore: drop `otk` (osbuild/images#1791) - Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza - distro: add a bootc distro (HMS-9176) (osbuild/images#1736) - Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger - distro: add support for filesystem from default_fs_type (HMS-8844) (osbuild/images#1713) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza - distrodefs/fedora: add supported customizations for net installer (osbuild/images#1768) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - fedora: do not mark images as firstboot (HMS-9222) (osbuild/images#1799) - Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers - image: add platform/filename to image.New*() (osbuild/images#1790) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-08-28 --- tag v0.182.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.182.0 ---------------- - distro: ensure correct bootc image type Filename() output (osbuild/images#1800) - Author: Michael Vogt, Reviewers: Ondřej Budai, Simon de Vlieger - distro: fedora: Update Minimal for some missing packages (osbuild/images#1803) - Author: Peter Robinson, Reviewers: Achilleas Koutsou, Simon de Vlieger - image,manifest: move installer metadata into InstallerCustomiaztions (osbuild/images#1789) - Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger — Somewhere on the Internet, 2025-08-28 --- tag v0.183.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.183.0 ---------------- - github: avoid single person code owners (osbuild/images#1795) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - github: enable validate checksums on the merge queue (osbuild/images#1805) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger - github: fix the validate checksums action on the merge queue (osbuild/images#1807) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger — Somewhere on the Internet, 2025-09-01 --- tag v0.184.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.184.0 ---------------- - Add repo definitions for RHEL-9.8 and RHEL-10.2 (HMS-9173) (osbuild/images#1812) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Sanne Raymaekers - Add support to set partition GPT attributes in yaml format (osbuild/images#1817) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt - Fix Azure grub menu visibility in serial console [RHEL-95423, RHEL-95418] (osbuild/images#1814) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza - Fix handling of root user in kickstart stage [RHEL-4644] (osbuild/images#1806) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza - Support raw payloads in yaml partition info (osbuild/images#1829) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt - Update dependencies 2025-08-31 (osbuild/images#1811) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Lukáš Zapletal - Update osbuild dependency commit ID to latest (osbuild/images#1810) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza - Update snapshots to 20250901 (osbuild/images#1815) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Tomáš Hozza - bootc: add support for /usr/lib/bootc-image-builder/disk.yaml (osbuild/images#1816) - Author: Michael Vogt, Reviewers: Alexander Larsson, Tomáš Hozza - distro: Fix build container use in bootc distro (osbuild/images#1822) - Author: Alexander Larsson, Reviewers: Achilleas Koutsou, Michael Vogt - distro: add bootc riscv partition table (osbuild/images#1794) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza - github: change yaml comment indentation to please linter (osbuild/images#1824) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Sanne Raymaekers - github: disable unit tests on distros without osbuild rpms (osbuild/images#1818) - Author: Achilleas Koutsou, Reviewers: Sanne Raymaekers, Tomáš Hozza - github: remove matrix value from test names (osbuild/images#1808) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza - github: run yaml checks on all yaml files (osbuild/images#1819) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Sanne Raymaekers, Tomáš Hozza - github: use git status to verify checksum changes (osbuild/images#1826) - Author: Achilleas Koutsou, Reviewers: Sanne Raymaekers, Tomáš Hozza - osbuild: inspect wrapper (HMS-8973) (osbuild/images#1715) - Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Lukáš Zapletal - test/data/manifest-checksums: add 10.2 and 9.8 (osbuild/images#1827) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Tomáš Hozza - test/scripts/boot-image: skip boot for non-x86_64 azure vhds (osbuild/images#1813) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Tomáš Hozza - test: ensure manifest from bib/images are identical (osbuild/images#1797) - Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza — Somewhere on the Internet, 2025-09-04 --- tag v0.185.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.185.0 ---------------- - distrodefs/fedora: support enabled_modules for image types with packages (osbuild/images#1831) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Michal Gold, Sanne Raymaekers, Tomáš Hozza — Somewhere on the Internet, 2025-09-04 --- tag v0.186.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.186.0 ---------------- - Fixes for blueprint option validation in Fedora [HMS-6871] (osbuild/images#1823) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza — Somewhere on the Internet, 2025-09-04 --- tag v0.187.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.187.0 ---------------- - tools: delete image-info (osbuild/images#1833) - Author: Tomáš Hozza, Reviewers: Lukáš Zapletal, Michael Vogt — Somewhere on the Internet, 2025-09-08 --- tag v0.188.0 Tagger: imagebuilder-bot <[email protected]> Changes with 0.188.0 ---------------- - RHEL-10: use GCP guest tools for GCE image type (HMS-9236) (osbuild/images#1832) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Michael Vogt - Update supported blueprint options for Fedora image types (osbuild/images#1838) - Author: Achilleas Koutsou, Reviewers: Michael Vogt, Tomáš Hozza - internal: add randutil.String() helper (osbuild/images#1830) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Tomáš Hozza - test/repos: use rpmrepo snapshot for 'rhui-azure-sap' (osbuild/images#1839) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Michael Vogt, Sanne Raymaekers — Somewhere on the Internet, 2025-09-08 ---

achilleas-k mentioned this pull request Feb 18, 2025

Externalise image definitions #1234

Closed

7 tasks

lzap reviewed Feb 18, 2025

View reviewed changes

pkg/blueprint/customizations.go Outdated Show resolved Hide resolved

github-actions bot added the Stale label Mar 22, 2025

supakeen removed the Stale label Mar 22, 2025

github-actions bot added the Stale label Apr 22, 2025

achilleas-k removed the Stale label Apr 22, 2025

achilleas-k changed the title ~~Generalise and clean up blueprint customization validation for image types~~ Generalise and clean up blueprint customization validation for image types (HMS-6871) May 15, 2025

achilleas-k mentioned this pull request May 15, 2025

Show an error or warning when a customization isn't supported for an image type #1531

Closed

3 tasks

github-actions bot added the Stale label Jun 15, 2025

github-actions bot closed this Jun 22, 2025

mvo5 reopened this Jun 23, 2025

github-actions bot removed the Stale label Jun 24, 2025

achilleas-k force-pushed the config-validation branch from b0d7013 to 65e9b75 Compare July 7, 2025 17:50

mvo5 reviewed Jul 8, 2025

View reviewed changes

pkg/distro/validator.go Outdated Show resolved Hide resolved

achilleas-k force-pushed the config-validation branch 2 times, most recently from 98a5ce1 to 3688a61 Compare July 16, 2025 15:21

mvo5 mentioned this pull request Jul 21, 2025

distro: bring per-distro checkOptions back #1678

Merged

mvo5 mentioned this pull request Jul 22, 2025

distro: move rhel9 into a generic distro #1645

Merged

achilleas-k force-pushed the config-validation branch 2 times, most recently from 6de113f to b95e402 Compare July 22, 2025 18:03

achilleas-k added 5 commits August 26, 2025 14:45

distro/fedora: support name, version, and description on all types

b086f79

All image types should support the name, version, and description fields of the blueprint.

test: add name, description, and version to all test blueprints

804ede5

Add a name, description, and version to all blueprints in test/configs/. Some unused configs have been deleted. The description is used to describe the purpose and sometimes origin of the test configuration.

distro: flatten listed check in validateSupportedConfig()

d7dc115

Reverse the listed check in validateSupportedConfig() to avoid the extra indentation of the 'else' condition.

achilleas-k dismissed mvo5’s stale review via d7dc115 August 26, 2025 12:45

achilleas-k force-pushed the config-validation branch from da86945 to d7dc115 Compare August 26, 2025 12:45

achilleas-k requested review from bcl, lzap and mvo5 August 26, 2025 12:46

mvo5 approved these changes Aug 26, 2025

View reviewed changes

supakeen approved these changes Aug 26, 2025

View reviewed changes

achilleas-k enabled auto-merge August 26, 2025 14:06

achilleas-k added this pull request to the merge queue Aug 26, 2025

Merged via the queue into osbuild:main with commit 83282bb Aug 26, 2025
23 checks passed

achilleas-k deleted the config-validation branch August 26, 2025 14:47

achilleas-k mentioned this pull request Sep 3, 2025

Fixes for blueprint option validation in Fedora [HMS-6871] #1823

Merged

achilleas-k mentioned this pull request Sep 4, 2025

go.mod: update osbuild/images to v0.188.0 osbuild/osbuild-composer#4849

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Generalise blueprint validation for Fedora image types (HMS-6871) #1216

Generalise blueprint validation for Fedora image types (HMS-6871) #1216

Uh oh!

achilleas-k commented Feb 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Mar 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Jun 15, 2025

Uh oh!

github-actions bot commented Jun 22, 2025

Uh oh!

mvo5 commented Jun 23, 2025

Uh oh!

lzap commented Jun 24, 2025

Uh oh!

Uh oh!

achilleas-k commented Aug 26, 2025

Uh oh!

supakeen left a comment

Uh oh!

mvo5 commented Aug 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Generalise blueprint validation for Fedora image types (HMS-6871) #1216

Generalise blueprint validation for Fedora image types (HMS-6871) #1216

Uh oh!

Conversation

achilleas-k commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Jun 15, 2025

Uh oh!

github-actions bot commented Jun 22, 2025

Uh oh!

mvo5 commented Jun 23, 2025

Uh oh!

lzap commented Jun 24, 2025

Uh oh!

Uh oh!

achilleas-k commented Aug 26, 2025

Uh oh!

supakeen left a comment

Choose a reason for hiding this comment

Uh oh!

mvo5 commented Aug 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

achilleas-k commented Feb 13, 2025 •

edited

Loading