manifest: remove most panics()#1883
Merged
Merged
Conversation
Collaborator
|
A previous version of this PR changed the images API or behaviour causing integration issues with image-builder-cli. |
Similar to the previous commits, move panics into errors. Some test needed adjustment and use `ErrorEqual()` now to show that the error message is also reasonable.
By making Pipeline.fileRefs() return an error we avoid another panic().
mvo5
force-pushed
the
no-manifests-errs2
branch
from
September 19, 2025 14:03
55ad0ac to
cbf3a6c
Compare
mvo5
marked this pull request as ready for review
September 19, 2025 14:04
lzap
approved these changes
Sep 19, 2025
lzap
enabled auto-merge
September 19, 2025 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #1882 we can not return errors in more places and need to panic less. This PR contains some followups to eliminate more panics. With it merged we go from 95 panics() in pkg/manifest to just 20 (most in serializeEnd, the rest in things like
getBuildPackages()which can be caused by unsupported architecutures, see https://github.com/osbuild/images/blob/v0.193.0/pkg/manifest/anaconda_installer.go#L127)