manifest: add error to Pipeline.serialize() #1882
Merged
Merged
Conversation
This commit makes the Pipeline.serialize() add support for error returns. This diff is purely automatic and does not change any of the existing panics into errors.
Collaborator
|
This PR changes the images API or behaviour causing integration failures with image-builder-cli. The next update of the images dependency in image-builder-cli will need work to adapt to these changes. This is simply a notice. It will not block this PR from being merged. |
mvo5
force-pushed
the
no-manifests-errs
branch
2 times, most recently
from
5b6fbde to
d1d7829
Compare
This commit changes the panics() in serialize() to errors.
With the panic() from serialize() gone we see a slightly different error message now. Adjust for that in the bootc tests.
mvo5
force-pushed
the
no-manifests-errs
branch
from
d1d7829 to
553c77a
Compare
achilleas-k
approved these changes
Sep 19, 2025
achilleas-k
left a comment
achilleas-k
left a comment
Member
There was a problem hiding this comment.
Awesome. This has been a long time coming. Let's keep this up!
THANK YOU!
LGTM
supakeen
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was suggested by Achilleas in #1879 (comment) - its a start if its liked I can do serialzeEnd() too and go over the "in-between" panics in the various helpers (e.g. anaconda_installer still has some indirect panics).
manifest: add
errorto Pipeline.serialize()This commit makes the Pipeline.serialize() add support for
error returns. This diff is purely automatic and does not
change any of the existing panics into errors.
manifest: convert panic() in serialize() to errors
This commit changes the panics() in serialize() to errors.