distro: fix kernel options for Fedora Azure image#166
Merged
Conversation
achilleas-k
force-pushed
the
rhel-9.3.0
branch
from
September 18, 2023 17:29
a1cc629 to
7a693f9
Compare
achilleas-k
force-pushed
the
rhel-9.3.0
branch
from
September 18, 2023 17:30
7a693f9 to
acbc426
Compare
achilleas-k
enabled auto-merge (rebase)
September 18, 2023 17:37
ondrejbudai
approved these changes
Sep 18, 2023
ondrejbudai
left a comment
ondrejbudai
left a comment
Member
There was a problem hiding this comment.
I don't fully understand why we need a Fedora-related change in a RHEL branch, but it also shouldn't do any harm, and you have my full trust as always. :)
Contributor
I believe it's because #163 contained some of those changes already |
Member
Author
I considered disabling the tests in the RHEL branch in osbuild-composer but decided fixing the issue would be better, even if a bit pointless. |
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Sep 18, 2023
Update images dependency to pull in change to minimal raw images [1] for release into RHEL 9.3.0. Includes fix for Azure image kernel options [2]. [1] osbuild/image-builder#163 [2] osbuild/image-builder#166
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Sep 18, 2023
Update images dependency to pull in change to minimal raw images [1] for release into RHEL 9.3.0. Includes fix for Azure image kernel options [2]. [1] osbuild/image-builder#163 [2] osbuild/image-builder#166
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Sep 18, 2023
Update images dependency to pull in change to minimal raw images [1] for release into RHEL 9.3.0. Includes fix for Azure image kernel options [2]. [1] osbuild/image-builder#163 [2] osbuild/image-builder#166
supakeen
pushed a commit
to osbuild/osbuild-composer
that referenced
this pull request
Sep 19, 2023
Update images dependency to pull in change to minimal raw images [1] for release into RHEL 9.3.0. Includes fix for Azure image kernel options [2]. [1] osbuild/image-builder#163 [2] osbuild/image-builder#166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During rebase of 3d36490, this change was missed due to 3d8388e.