-
Notifications
You must be signed in to change notification settings - Fork 22
data/azure/grub9.6+: update expected grub config #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Azure‐specific GRUB golden configuration for RHEL 9.6+ by regenerating the expected config to align with the latest osbuild/images changes and the corresponding RHEL bug fixes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Does the CI here run the CIV against osbuild-composer's |
Update the expected grub config to match the latest changes. osbuild/images#1814 RHEL 9: RHEL-95423 RHEL 10: RHEL-95418
5050f57 to
4915532
Compare
alexxa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
CIV was recently updated [1] to cover changes in the upstream image definitions [2]. The 'rhel-azure-grub-serial-io' tag does not include those changes. The nightly tests for 9.7 and 10.1 should run with the older image definitions that do not include the changes [1] osbuild/cloud-image-val#457 [2] osbuild/images#1814
CIV was recently updated [1] to cover changes in the upstream image definitions [2] in Azure images. The 'rhel-azure-grub-serial-io' tag does not include those changes. Older versions of osbuild-composer are being tested in nightlies for 9.7 and 10.1, so it should run with the older image definitions that do not include the changes. [1] osbuild/cloud-image-val#457 [2] osbuild/images#1814
CIV was recently updated [1] to cover changes in the upstream image definitions [2] in Azure images. The 'pr-456' tag is the latest that does not include those changes. Older versions of osbuild-composer are being tested in nightlies for 9.7 and 10.1, so it should run with the older image definitions that do not include the changes. [1] osbuild/cloud-image-val#457 [2] osbuild/images#1814
CIV was recently updated [1] to cover changes in the upstream image definitions [2] in Azure images. The 'pr-456' tag is the latest that does not include those changes. Older versions of osbuild-composer are being tested in nightlies for 9.7 and 10.1, so it should run with the older image definitions that do not include the changes. [1] osbuild/cloud-image-val#457 [2] osbuild/images#1814
Update the expected grub config to match the latest changes.
osbuild/images#1814
RHEL 9: RHEL-95423
RHEL 10: RHEL-95418
Summary by Sourcery
Tests: