Skip to content

blueprint: installer kernel args (RHEL-107495) #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
supakeen wants to merge 1 commit into from
Closed

blueprint: installer kernel args (RHEL-107495) #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions pkg/blueprint/installer_customizations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package blueprint

type InstallerCustomization struct {
Unattended bool `json:"unattended,omitempty" toml:"unattended,omitempty"`
SudoNopasswd []string `json:"sudo-nopasswd,omitempty" toml:"sudo-nopasswd,omitempty"`
Kickstart *Kickstart `json:"kickstart,omitempty" toml:"kickstart,omitempty"`
Modules *AnacondaModules `json:"modules,omitempty" toml:"modules,omitempty"`
Unattended bool `json:"unattended,omitempty" toml:"unattended,omitempty"`
SudoNopasswd []string `json:"sudo-nopasswd,omitempty" toml:"sudo-nopasswd,omitempty"`
Kickstart *Kickstart `json:"kickstart,omitempty" toml:"kickstart,omitempty"`
Modules *AnacondaModules `json:"modules,omitempty" toml:"modules,omitempty"`
Kernel *InstallerKernelCustomization `json:"kernel,omitempty" toml:"kernel,omitempty"`

@mvo5 mvo5 Aug 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a short comment here (or in the commit message) why we need a new customization and we can't just use the existing "KernelCustomization" that are used for disk images. I don't know the details but maybe: // installer needs their own customizations so that we can tweak the installed system via the existing KernelCustomizations or something (assuming that is true and the reason of course :)

@supakeen supakeen Aug 8, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we (@achilleas-k and me) wanted to discuss in this PR. We can do either approach.

In general for installers Anaconda will handle setting up the kernel arguments and bootloader for the system being installed, thus there's no need to separate them.

@supakeen supakeen Aug 8, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that I only referred to this in the images counterpart of this PR: osbuild/image-builder#1727 (comment)

}

type Kickstart struct {
Expand All @@ -15,3 +16,7 @@ type AnacondaModules struct {
Enable []string `json:"enable,omitempty" toml:"enable,omitempty"`
Disable []string `json:"disable,omitempty" toml:"disable,omitempty"`
}

type InstallerKernelCustomization struct {
Append string `json:"append" toml:"append"`
}
Loading