blueprint: installer kernel args (RHEL-107495)#25
Conversation
|
No longer necessary with the removal of the internal blueprint versions in images. |
supakeen
force-pushed
the
installer-kernel
branch
from
606269f to
db5989e
Compare
Allows for the customization of kernel arguments as used by installer environments. Anaconda takes certain actions based on the kernel arguments supplied such as configuring the installed system with them. We've had the ability to customize these for disk images for a while now. We also need them for installers. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
supakeen
force-pushed
the
installer-kernel
branch
from
db5989e to
8cb0053
Compare
| SudoNopasswd []string `json:"sudo-nopasswd,omitempty" toml:"sudo-nopasswd,omitempty"` | ||
| Kickstart *Kickstart `json:"kickstart,omitempty" toml:"kickstart,omitempty"` | ||
| Modules *AnacondaModules `json:"modules,omitempty" toml:"modules,omitempty"` | ||
| Kernel *InstallerKernelCustomization `json:"kernel,omitempty" toml:"kernel,omitempty"` |
There was a problem hiding this comment.
Maybe a short comment here (or in the commit message) why we need a new customization and we can't just use the existing "KernelCustomization" that are used for disk images. I don't know the details but maybe: // installer needs their own customizations so that we can tweak the installed system via the existing KernelCustomizations or something (assuming that is true and the reason of course :)
There was a problem hiding this comment.
This is something we (@achilleas-k and me) wanted to discuss in this PR. We can do either approach.
In general for installers Anaconda will handle setting up the kernel arguments and bootloader for the system being installed, thus there's no need to separate them.
There was a problem hiding this comment.
I see now that I only referred to this in the images counterpart of this PR: osbuild/image-builder#1727 (comment)
|
We decided we're dropping this, right? We'll instead apply the regular |
Yes, and rewrite the one in images to use those. |
3 participants
Allows for the customization of kernel arguments as used by installer environments. Anaconda takes certain actions based on the kernel arguments supplied such as configuring the installed system with them.
We've had the ability to customize these for disk images for a while now. We also need them for installers.