Repository navigation
Add initial hub testing and documentation. - #3
Conversation
|
Can you open a PR which add a workflow that runs |
|
I feel there is a lot of AI in there, some things doesn't make sense. Can you please review the code first? and then I'll review. |
|
The failing pre-commit checks indicate you're not running these pre-commit checks locally. You probably want to update your repository so that these checks are run automatically whenever you make a commit. That should be as simple as:
This will configure your |
…tion - Add README.md with project documentation - Add Apache License 2.0 (LICENSE) - Basic hub testing
jkary
changed the title
jhernand
left a comment
jhernand
left a comment
There was a problem hiding this comment.
Some minor comments, but overall it looks good as an starting point.
|
|
||
| # Default test configuration | ||
| test_namespace: foobar | ||
| testing_workspace: /tmp/cloudkit-e2e-testing |
There was a problem hiding this comment.
Is this meant to be ephemeral (deleted automatically after the test is complete), or persistent (contains artifacts of the test that may be of interest to somebody)?
There was a problem hiding this comment.
If the tests all pass then it should be ephemeral. If there is an error then it should be persistent. I'm not sure of a good way to do this in GH actions.
| ansible.builtin.command: | ||
| cmd: oc whoami | ||
| environment: | ||
| kubeconfig: "{{ mgmt_kubeconfig }}" |
There was a problem hiding this comment.
Should this be KUBECONFIG instead of kubeconfig? The KUBECONFIG variable is supported by both oc and kubectl, whereas neither respond to kubeconfig.
4 participants
Summary
Test plan
🤖 Generated with Claude Code