Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Merge user-provided template parameters when defined - #4

Merged
adriengentil merged 1 commit into
osac-project:mainfrom
adriengentil:fix-undefined-template-parameters
Apr 4, 2025
Merged

Merge user-provided template parameters when defined#4
adriengentil merged 1 commit into
osac-project:mainfrom
adriengentil:fix-undefined-template-parameters

Conversation

@adriengentil

@adriengentil adriengentil commented Apr 4, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved configuration parameter merging by ensuring default values combine with custom inputs only when custom settings are provided, reducing the risk of errors.

@adriengentil
adriengentil merged commit ca803c0 into osac-project:main Apr 4, 2025
@coderabbitai

coderabbitai Bot commented Apr 4, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

A conditional statement was added to the logic responsible for merging default template parameters with user-supplied parameters. The merging operation now only occurs if the user-provided parameters (cluster_settings_template_parameters) are defined. This ensures that the merge process does not attempt to combine undefined values, potentially avoiding runtime errors. Additionally, there were no modifications made to the declarations of exported or public entities in this update.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b8e684 and 8ea6c4e.

📒 Files selected for processing (1)
  • roles/cluster_settings/tasks/main.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

trewest added a commit to trewest/osac-aap that referenced this pull request Apr 7, 2026
@trewest @claude
feat(01-02): implement conditional VPC and prefix deletion
cddc2f8 
- Retrieve ConfigMap to determine what was created vs pre-existing
- Delete VPC prefix only if prefix_created flag is true
- Delete VPC only if vpc_created flag is true
- Default to delete if ConfigMap missing (safe fallback per D-10)
- Deletion order: prefix → VPC → ConfigMap (reverse of creation)
- All Carbide API deletions use ignore_errors for safety (pitfall osac-project#4)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
trewest added a commit to trewest/osac-aap that referenced this pull request Apr 15, 2026
@trewest @claude
feat(01-02): implement conditional VPC and prefix deletion
bd747ab 
- Retrieve ConfigMap to determine what was created vs pre-existing
- Delete VPC prefix only if prefix_created flag is true
- Delete VPC only if vpc_created flag is true
- Default to delete if ConfigMap missing (safe fallback per D-10)
- Deletion order: prefix → VPC → ConfigMap (reverse of creation)
- All Carbide API deletions use ignore_errors for safety (pitfall osac-project#4)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
trewest added a commit to trewest/osac-aap that referenced this pull request Apr 21, 2026
@trewest @claude
feat(01-02): implement conditional VPC and prefix deletion
6c7a9a4 
- Retrieve ConfigMap to determine what was created vs pre-existing
- Delete VPC prefix only if prefix_created flag is true
- Delete VPC only if vpc_created flag is true
- Default to delete if ConfigMap missing (safe fallback per D-10)
- Deletion order: prefix → VPC → ConfigMap (reverse of creation)
- All Carbide API deletions use ignore_errors for safety (pitfall osac-project#4)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
trewest added a commit to trewest/osac-aap that referenced this pull request Apr 21, 2026
@trewest @claude
feat(01-02): implement conditional VPC and prefix deletion
416e927 
- Retrieve ConfigMap to determine what was created vs pre-existing
- Delete VPC prefix only if prefix_created flag is true
- Delete VPC only if vpc_created flag is true
- Default to delete if ConfigMap missing (safe fallback per D-10)
- Deletion order: prefix → VPC → ConfigMap (reverse of creation)
- All Carbide API deletions use ignore_errors for safety (pitfall osac-project#4)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@osac-jira-ai-issue-solver osac-jira-ai-issue-solver Bot mentioned this pull request Jul 2, 2026
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jhernand jhernand jhernand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adriengentil @jhernand