OSAC-1699: QoS policies created with wrong type for block storage tiers

[osac-jira-ai-issue-solver]

Resolves OSAC-1699

Summary

QoS policies created with wrong type for block storage tiers

Description

Summary
The create_qos_policy.yaml task in the vast_storage Ansible role creates all QoS policies with policy_type: "VIEW". Block storage tiers require policy_type: "VOLUME" — the VAST API rejects block volume creation with "Only VOLUME QOSPolicies can be used for Volumes" (HTTP 400).
Steps to Reproduce
Provision a tenant with a storage tier that uses protocol: block (e.g., a performance tier)
Observe that create_qos_policy.yaml creates the QoS policy with policy_type: "VIEW" regardless of tier protocol
Block volume creation fails with HTTP 400: "Only VOLUME QOSPolicies can be used for Volumes"
Impact
Any tenant provisioning that includes block protocol tiers fails at QoS policy creation time. NFS tiers are unaffected since they use view-level QoS.
Environment
Discovered during OSAC-1326 RBAC Realm e2e testing on VAST 5.4.1.
Affected File
collections/ansible_collections/osac/templates/roles/vast_storage/tasks/create_qos_policy.yaml
Fix
The create_qos_policy.yaml task needs to set policy_type dynamically based on the tier's protocol:
VIEW for NFS tiers
VOLUME for block tiers

[osac-jira-ai-issue-solver]

AI Session Costs

Session	Cost
New ticket	$3.62
Feedback #1	$0.66
Feedback #2	$0.51
Feedback #3	$0.62
Feedback #4	$0.33
Feedback #5	$2.96
Feedback #6	$3.42
Feedback #7	$0.75
Feedback #8	$0.43
Feedback #9	$0.42
Feedback #10	$0.34
Total	$14.06

[openshift-ci-robot]

@osac-jira-ai-issue-solver[bot]: This pull request references OSAC-1699 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Resolves OSAC-1699

Summary

QoS policies created with wrong type for block storage tiers

Description

Summary
The create_qos_policy.yaml task in the vast_storage Ansible role creates all QoS policies with policy_type: "VIEW". Block storage tiers require policy_type: "VOLUME" — the VAST API rejects block volume creation with "Only VOLUME QOSPolicies can be used for Volumes" (HTTP 400).
Steps to Reproduce
Provision a tenant with a storage tier that uses protocol: block (e.g., a performance tier)
Observe that create_qos_policy.yaml creates the QoS policy with policy_type: "VIEW" regardless of tier protocol
Block volume creation fails with HTTP 400: "Only VOLUME QOSPolicies can be used for Volumes"
Impact
Any tenant provisioning that includes block protocol tiers fails at QoS policy creation time. NFS tiers are unaffected since they use view-level QoS.
Environment
Discovered during OSAC-1326 RBAC Realm e2e testing on VAST 5.4.1.
Affected File
collections/ansible_collections/osac/templates/roles/vast_storage/tasks/create_qos_policy.yaml
Fix
The create_qos_policy.yaml task needs to set policy_type dynamically based on the tier's protocol:
VIEW for NFS tiers
VOLUME for block tiers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @osac-jira-ai-issue-solver[bot]. Thanks for your PR.

I'm waiting for a osac-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[osac-jira-ai-issue-solver]

In comment, @openshift-ci-robot said:

@osac-jira-ai-issue-solver[bot]: This pull request references OSAC-1699 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Resolves OSAC-1699

Summary

QoS policies created with wrong type for block storage tiers

Description

Summary
The create_qos_policy.yaml task in the vast_storage Ansible role creates all QoS policies with policy_type: "VIEW". Block storage tiers require policy_type: "VOLUME" — the VAST API rejects block volume creation with "Only VOLUME QOSPolicies can be used for Volumes" (HTTP 400).
Steps to Reproduce
Provision a tenant with a storage tier that uses protocol: block (e.g., a performance tier)
Observe that create_qos_policy.yaml creates the QoS policy with policy_type: "VIEW" regardless of tier protocol
Block volume creation fails with HTTP 400: "Only VOLUME QOSPolicies can be used for Volumes"
Impact
Any tenant provisioning that includes block protocol tiers fails at QoS policy creation time. NFS tiers are unaffected since they use view-level QoS.
Environment
Discovered during OSAC-1326 RBAC Realm e2e testing on VAST 5.4.1.
Affected File
collections/ansible_collections/osac/templates/roles/vast_storage/tasks/create_qos_policy.yaml
Fix
The create_qos_policy.yaml task needs to set policy_type dynamically based on the tier's protocol:
VIEW for NFS tiers
VOLUME for block tiers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

I was unable to produce code changes to address this comment after multiple attempts.

[osac-jira-ai-issue-solver]

In comment, @openshift-ci[bot] said:

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: osac-jira-ai-issue-solver[bot]
Once this PR has been reviewed and has the lgtm label, please assign akshaynadkarni for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I was unable to produce code changes to address this comment after multiple attempts.

[osac-jira-ai-issue-solver]

In comment, @openshift-ci[bot] said:

Hi @osac-jira-ai-issue-solver[bot]. Thanks for your PR.

I'm waiting for a osac-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

I was unable to produce code changes to address this comment after multiple attempts.

[osac-jira-ai-issue-solver]

CI failures addressed in multi-repo.

[osac-jira-ai-issue-solver]

CI failures addressed in multi-repo.

[wgordon17]

Fix looks correct. QoS policy_type is now set dynamically based on tier protocol (VIEW for NFS, VOLUME for block). The rejectattr filter removal and ensure_storage_class qos_policy passthrough are both needed. Integration tests cover the new path with explicit policy_type assertions. All CI green.

[osac-jira-ai-issue-solver]

In comment, @openshift-ci[bot] said:

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: osac-jira-ai-issue-solver[bot], wgordon17
Once this PR has been reviewed and has the lgtm label, please assign akshaynadkarni for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I was unable to produce code changes to address this comment after multiple attempts.

[osac-jira-ai-issue-solver]

In comment, @wgordon17 said:

Fix looks correct. QoS policy_type is now set dynamically based on tier protocol (VIEW for NFS, VOLUME for block). The rejectattr filter removal and ensure_storage_class qos_policy passthrough are both needed. Integration tests cover the new path with explicit policy_type assertions. All CI green.

I was unable to produce code changes to address this comment after multiple attempts.

[eranco74]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, osac-jira-ai-issue-solver[bot], wgordon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [eranco74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment