Conversation
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
===========================================
+ Coverage 66.49% 77.79% +11.30%
===========================================
Files 107 81 -26
Lines 4796 3873 -923
===========================================
- Hits 3189 3013 -176
+ Misses 1325 587 -738
+ Partials 282 273 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hperl
commented
Sep 1, 2022
zepatrik
reviewed
Sep 2, 2022
Member
zepatrik
left a comment
There was a problem hiding this comment.
This looks very good, just found some minor things 🎉
39920db to
5ef9120
Compare
25c5629 to
a998323
Compare
zepatrik
previously approved these changes
Sep 6, 2022
aeneasr
requested changes
Sep 7, 2022
Member
There was a problem hiding this comment.
Great! This is basically in a mergable state with a few questions and requirements:
- in
health_test.goit looks as if the health payloads have changed. If so, we should add this as a breaking change. Can you please update the PR description to match the changes made? - some configuration environment variables have been deprecated, please add those to the breaking changes list above.
- check that the removed env vars are not used in helm charts and in ory cloud
- Search the documentation for removed config keys and remove them
7 tasks
* bump ory/x deps * update to new httpx, metricsx * cleanup viper config
* revert schema * bump swagger * remove extra sets * simplify CORS settings getter * move to resilitent httpx completely
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
80de07c to
cd272a7
Compare
Contributor
Author
Done, no references to |
121e3c5 to
f33dce4
Compare
* remove broken caching for e2e tests * re-add `--config` flag
f33dce4 to
78c0acb
Compare
aeneasr
approved these changes
Sep 8, 2022
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR swaps the configuration library from viperx for koanf and updates the dependencies, most importantly to
ory/x.This work relates to the effort to use Oathkeeper as a gRPC/HTTP middleware in other projects.
Fixes #757
Breaking changes
status,code, andmessageJAEGER_PROPAGATIONwas removed. UseTRACING_PROVIDER_JAEGER_PROPAGATION