fix: allow otel tracing provider in config#1039
Merged
aeneasr merged 2 commits intoory:masterfrom Dec 1, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1039 +/- ##
=======================================
Coverage 78.70% 78.70%
=======================================
Files 83 83
Lines 3869 3869
=======================================
Hits 3045 3045
Misses 554 554
Partials 270 270
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aeneasr
approved these changes
Dec 1, 2022
Member
|
Hello @jgraeger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to allow usage of the open telemetry tracing provider of ory/x in oathkeeper. As ory/x has been updated to a recent version in #999, this came down to a small change in the configuration schema.
Related issue(s)
Oathkeeperdoes not respectTRACING_PROVIDER=otel#888Checklist
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments