Skip to content

Conversation

@idodeclare
Copy link
Contributor

Hello,

Please consider for integration this patch to add a --nestingMaximum switch to help user @sirisan who has a RepoRepository setup with two levels of nesting.

Default will continue to be just one level.

Thank you.

@coveralls
Copy link

coveralls commented May 27, 2020

Pull Request Test Coverage Report for Build 5184

  • 14 of 18 (77.78%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 73.443%

Changes Missing Coverage Covered Lines Changed/Added Lines %
opengrok-indexer/src/main/java/org/opengrok/indexer/history/HistoryGuru.java 4 5 80.0%
opengrok-indexer/src/main/java/org/opengrok/indexer/index/Indexer.java 2 3 66.67%
opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/Configuration.java 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
opengrok-indexer/src/main/java/org/opengrok/indexer/history/HistoryGuru.java 1 69.18%
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java 4 53.49%
Totals Coverage Status
Change from base Build 5182: 0.06%
Covered Lines: 37887
Relevant Lines: 51587

💛 - Coveralls

@idodeclare
Copy link
Contributor Author

@tulinkry, thank you for the review!

@tarzanek
Copy link
Contributor

lgtm, merging

@tarzanek
Copy link
Contributor

thanks guys!

@tarzanek tarzanek merged commit cff3e28 into oracle:master Jun 22, 2020
@idodeclare
Copy link
Contributor Author

Thank you, @tarzanek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants