Fix #770 Fix #1351 : use PathAccepter in FileHistoryCache #3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5244
💛 - Coveralls |
Contributor
|
sorry, did it again, merged your other patch and created conflicts |
idodeclare
force-pushed
the
feature/ignore_history
branch
from
c654f46 to
cc0f13c
Compare
Contributor
Author
No worries, Lubos. Now rebased (just conflicts in copyright — your favorite). Thank you for taking a look. |
Contributor
Author
|
Oh no I tried the Github conflict resolver, but I don't like that it merged master into this branch. I'm revising.... |
idodeclare
force-pushed
the
feature/ignore_history
branch
from
d6f729b to
fda1696
Compare
Contributor
Author
|
It was just a tiny conflict in |
idodeclare
force-pushed
the
feature/ignore_history
branch
from
fda1696 to
bee2185
Compare
Contributor
Author
|
Rebased for minor conflicts after #3154 |
- Extract path-based including/ignoring to configuration - Also, relocate Filter, IgnoredDirs, IgnoredFiles, IgnoredNames to configuration
Contributor
Author
|
Just resolving a conflict in copyright... |
idodeclare
force-pushed
the
feature/ignore_history
branch
from
bee2185 to
ced8d70
Compare
Member
|
Looks quite clean, thanks ! |
Contributor
Author
|
Thank you, @vladak! |
This was referenced Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider for integration this patch to extract a small bit of logic from
IndexDatabaseso that history generation will respect ignored files/dirs as well as explicitly included files.The symlink logic from
IndexDatabasedoes not have to be lifted out, since history generation already handlesForbiddenSymlinkException. Including the symlink itself as a listed file in history is not an issue.Also, this patch relocates
Filter,IgnoredDirs,IgnoredFiles, andIgnoredNamestoconfiguration.Thank you.