Refactor order of bucketing logic #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 24, 2017 17:07
Summary: Move bucketing logic around such that `activate` and `track` end up calling `getVariation` and we avoid some of the duplicate logic. The order of operations now should be: 1. Preconditions 2. Experiment status (Must be running or launched) 3. Whitelisting 4. User profile (if available) 5. Audience conditions 6. Bucket through bucketer Test Plan: Unit. Will test manually. Reviewers: #oasis_team_review JIRA Issues: OASIS-1170 Differential Revision: https://phabricator.optimizely.com/D15336
Contributor
Author
|
@aliabbasrizvi please approve this now that you've deployed 1.1.1 |
aliabbasrizvi
approved these changes
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@optimizely/fullstack-devs