Skip to content

Commit 5e815aa

Browse files
author
Mike Ng
committed
Address final nits.
1 parent 0d66ccb commit 5e815aa

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/Optimizely/Event/Builder/EventBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ public function createImpressionEvent($config, $experimentKey, $variationKey, $u
217217
*
218218
* @param $config ProjectConfig Configuration for the project.
219219
* @param $eventKey string Key representing the event.
220-
* @param $experimentVariationMap array Map of experiment id to the id of the variation that the user is bucketed into
220+
* @param $experimentVariationMap array Map of experiment ID to the ID of the variation that the user is bucketed into.
221221
* @param $userId string ID of user.
222222
* @param $attributes array Attributes of the user.
223223
* @param $eventTags array Hash representing metadata associated with the event.

src/Optimizely/Optimizely.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,13 +191,13 @@ private function validateUserInputs($attributes, $eventTags = null) {
191191

192192
/**
193193
* Get the experiments that we should be tracking for the given event. A valid experiment
194-
* is one that is in "Running" state and for which the user has been bucketed into.
194+
* is one that is in "Running" state and into which the user has been bucketed.
195195
*
196196
* @param $event string Event key representing the event which needs to be recorded.
197197
* @param $user string ID for user.
198198
* @param $attributes array Attributes of the user.
199199
*
200-
* @return Array Of objects where each object contains the id of the experiment to track and the id of the variation the user is bucketed into.
200+
* @return Array Of objects where each object contains the ID of the experiment to track and the ID of the variation the user is bucketed into.
201201
*/
202202
private function getValidExperimentsForEvent($event, $userId, $attributes = null) {
203203
$validExperiments = [];

tests/BucketerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ public function testBucketInvalidExperiment()
282282
);
283283
}
284284

285-
public function testBucketValidExperimentNotInGroupUserInForcedVariation()
285+
public function testGetForcedVariationExperimentNotInGroupUserInForcedVariation()
286286
{
287287
$bucketer = new Bucketer($this->loggerMock);
288288
$this->loggerMock->expects($this->once())
@@ -295,7 +295,7 @@ public function testBucketValidExperimentNotInGroupUserInForcedVariation()
295295
);
296296
}
297297

298-
public function testBucketValidExperimentInGroupUserInForcedVariation()
298+
public function testGetForcedVariationExperimentInGroupUserInForcedVariation()
299299
{
300300
$bucketer = new Bucketer($this->loggerMock);
301301
$this->loggerMock->expects($this->once())

0 commit comments

Comments
 (0)