Skip to content

fix(docs): Return type should be ProjectConfigInterface #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2022
Merged

fix(docs): Return type should be ProjectConfigInterface #249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
850f123
fix(docs): Return type should be ProjectConfigInterface
adri Mar 29, 2022
1dabab4
Merge branch 'master' into pr-240
msohailhussain May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Optimizely/Config/DatafileProjectConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ private function getAllRulesForFlag(FeatureFlag $flag)
* @param bool $skipJsonValidation boolean representing whether JSON schema validation needs to be performed.
* @param LoggerInterface $logger Logger instance
* @param ErrorHandlerInterface $errorHandler ErrorHandler instance.
* @return ProjectConfig ProjectConfig instance or null;
* @return ProjectConfigInterface ProjectConfig instance or null;
*/
public static function createProjectConfigFromDatafile($datafile, $skipJsonValidation, $logger, $errorHandler)
{
Expand Down