Skip to content

fix(docs): Return type should be ProjectConfigInterface #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2022
Merged

fix(docs): Return type should be ProjectConfigInterface #249

merged 2 commits into from
May 31, 2022

Conversation

@msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented May 31, 2022

Background

This PR is copied from PR-240 contributed by @adri, Since that PR is closed by the contributor so adding this PR.

Summary

  • ProjectConfigInterface is the one used across SDK.

Test plan

  • All test must pass.

@msohailhussain msohailhussain requested a review from a team as a code owner May 31, 2022 16:54
jaeopt
jaeopt approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented May 31, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.007%) to 97.774% when pulling 1dabab4 on pr-240 into 7fc037d on master.

@msohailhussain msohailhussain merged commit 0cfe620 into master May 31, 2022
@msohailhussain msohailhussain deleted the pr-240 branch May 31, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@msohailhussain msohailhussain

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@msohailhussain @coveralls @jaeopt @adri