[Website] Allow Card Titles to have two lines #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
samuelstroschein
temporarily deployed
to
disable-line-clamp-on-marketplace-titles - badge-service PR #1822
Render
Destroyed
samuelstroschein
temporarily deployed
to
disable-line-clamp-on-marketplace-titles - git-proxy PR #1822
Render
Destroyed
samuelstroschein
temporarily deployed
to
disable-line-clamp-on-marketplace-titles - inlang-website PR #1822
Render
Destroyed
flornkm
reviewed
Dec 5, 2023
flornkm
approved these changes
Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the line-clamp on the card titles from one to two.
Having just one line is insufficient for a properly descriptive title. Important information either had to be omitted (bad for SEO), or we had to accept that it would cut off (bad UX).
With the two-line titles we now have a litte more space.
Using
text-wrap: balancemakes the wrapping a little nicer.Screen.Recording.2023-12-05.at.09.23.28.mov