-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #4178: Added dark mode support to PinPasswordActivity #4380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhaktideshmukh Please do following things:
- Check the checklist correctly in the PR description.
- Add the link of dark-mode mock in PR description.
- Also add screenshot showing error color too which gets displayed when you enter incorrect pin.
Done all the three things |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhaktideshmukh Please update the error color as mentioned here: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/9f441ec1-76e4-43e3-badf-42e70d584ab6/specs/
Unassigning @rt4914 since the review is done. |
Hi @bhaktideshmukh, it looks like some changes were requested on this pull request by @rt4914. PTAL. Thanks! |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Explanation
Fixes part of #4178 : Added dark mode support to PinPasswordActivity.
Mock link : https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/81c45a9d-5c70-46f0-8b02-b57a3df3ff50/specs/
Screenshots
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: