Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark mode support to OnboardingActivity and PinPasswordActivity #4178

Closed
ayush0402 opened this issue Feb 13, 2022 · 3 comments
Closed

Add dark mode support to OnboardingActivity and PinPasswordActivity #4178

ayush0402 opened this issue Feb 13, 2022 · 3 comments
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@ayush0402
Copy link
Contributor

ayush0402 commented Feb 13, 2022 •
edited
Loading

Add dark mode support to OnboardingActivity and PinPasswordActivity.

Go through this wiki to get started.
@pandayed
Copy link
Contributor

Please assign this to me.

@ayush0402
Copy link
Contributor Author

@xpandeyed Assigned.

@bhaktideshmukh bhaktideshmukh self-assigned this May 31, 2022
This was referenced Jun 1, 2022
Merged
Merged
rt4914 pushed a commit that referenced this issue Jun 6, 2022
@bhaktideshmukh
Fixes part of #4178: Added dark mode support to PinPasswordActivity (#…
44a76be 
…4380)

* added dark mode for pin_password

* renamed show string color

* added error color

* added show_hide_eye icon color
rt4914 pushed a commit that referenced this issue Jun 8, 2022
@bhaktideshmukh
Fixes part of #4178 : Added dark mode support to OnboardingActivity (#…
b0d74e9 
…4379)

* added dark mode for onboarding

* optimised component_colors

* changed fillColor in landscape files

* nit change
@Broppia Broppia added issue_type_feature Impact: Low Low perceived user impact (e.g. edge cases). labels Jun 13, 2022
@rt4914
Copy link
Contributor

rt4914 commented Aug 31, 2022

This has been finished. The related PRs are #4379 & #4380

@rt4914 rt4914 closed this as completed Aug 31, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rt4914 @BenHenning @pandayed @ayush0402 @bhaktideshmukh @Broppia