Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[61293] Sub-headlines are larger than the actual PageHeader #239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HDinger
Copy link
Collaborator

@HDinger HDinger commented Feb 6, 2025

What are you trying to accomplish?

  • Increase font-weight for PageHeaders to have more visibility in the page structure
  • Create Primer::OpenProject::Heading for our specific content headers which should be less prominent and have a lower font-weight

List the issues that this change affects.

Closes https://community.openproject.org/projects/design-system/work_packages/61293/github

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: 5aabb9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented Feb 6, 2025

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

@HDinger
Copy link
Collaborator Author

HDinger commented Feb 6, 2025

⚠️ The snapshots revealed something I overlooked before. I will double check. So do not merge until then

@myabc myabc self-requested a review February 6, 2025 14:11
@HDinger HDinger force-pushed the bug/61293-sub-headlines-are-larger-than-the-actual-pageheader-on-meetings-index-page branch from 80fbf87 to c5779aa Compare February 7, 2025 10:58
@HDinger HDinger requested a review from myabc February 7, 2025 11:00
…ht && increase font-weight for PageHeaders to have more visibility in the page structure
@HDinger HDinger force-pushed the bug/61293-sub-headlines-are-larger-than-the-actual-pageheader-on-meetings-index-page branch from c5779aa to 2724f0c Compare February 7, 2025 11:01
Copy link

@myabc myabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@myabc myabc self-requested a review February 7, 2025 15:34
Copy link

@myabc myabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it looks like there are a couple style lint failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants