commonLabels and commonAnnotations#188
Merged
oliverguenther merged 4 commits intoopf:mainfrom Sep 19, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: a3f6bf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
would love to see that merged, we have a similar issue with velero needing labels! |
a91b4b4 to
a3f6bf0
Compare
oliverguenther
approved these changes
Sep 18, 2025
Member
oliverguenther
left a comment
There was a problem hiding this comment.
Sorry this got lost for so long, but I've finally found time to include this. I extended it with a spec to ensure coverage and allow additional labels per web/worker deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit:
This PR fixes setting labels and annotations on resources. Using
bitnami/common'scommonLabelsandcommonAnnotations, "global" labels and annotations may be set which will be added to all resources.On certain resources, i.e. for
cron,ingress,persistence,seederJob,serviceAccountandopenproject"custom annotations may be set, which will be added together with thecommonAnnotations.I tested it with
helm template test-release . -f customvalues.yamlwhere mycustomvalues.yamllooks like:Note that memcached and postgresql need the labels and annotations to be passed again as they are not being added automatically (thus doubling config).
Original PR message:
also, add commonLabels as empty dicts in
values.yaml"for visibility".This PR tries to fix the issue stated in issue #178
EDIT: Note, all "matchLabels" used in selectors were NOT checked, I only tested for setting custom labels which did work with this dummy
customlabels.yaml