Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround on securityContext.runAsUser error #4368

Closed
wants to merge 6 commits into from

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Jan 7, 2021

Adding note about workaround to doc page at:
https://sdk.operatorframework.io/docs/faqs/

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@asmacdo
Copy link
Member

asmacdo commented Jan 11, 2021

/hold

Before we merge this, lets try to address upstream. #4364 (comment)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2021
@jmrodri
Copy link
Member

jmrodri commented Jan 31, 2021

@bentito can you rebase this PR. I was going to merge it tonight but saw the conflict. Sorry for the delay, looks like this has been open for quite a while.

@estroz
Copy link
Member

estroz commented Feb 2, 2021

This was fixed in kubernetes-sigs/kubebuilder#1978. There should be a migration guide to update the manager.yaml instead of an FAQ.

@bentito
Copy link
Contributor Author

bentito commented Feb 3, 2021

This was fixed in kubernetes-sigs/kubebuilder#1978. There should be a migration guide to update the manager.yaml instead of an FAQ.

@estroz Sounds like I should just close this PR as unneeded then?

@estroz
Copy link
Member

estroz commented Feb 3, 2021

@bentito yeah this will be resolved by #4402

@bentito
Copy link
Contributor Author

bentito commented Feb 3, 2021

Closing per @estroz comment.

@bentito bentito closed this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants