-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (go/v3) change 'runAsUser: 65532' to 'runAsNonRoot: true' #1978
✨ (go/v3) change 'runAsUser: 65532' to 'runAsNonRoot: true' #1978
Conversation
…ot: true' Signed-off-by: Eric Stroczynski <[email protected]>
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (not adding the label too early to let others review it if needed as it is already aproved)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
IMO to allow it gets merged, we need to ensure that after that the following error will not be faced.
It was the motivation for the change raised in #1637. So, we would need to check it with @harpratap. @harpratap could you please let us know if after this change the above error will be faced? Are you ok with? |
@camilamacedo86 both the conditions listed in #1637 no longer hold (both Dockerfiles now specify non-root user IDs) so this will work with a restrictive pod security policy. You can check this yourself by applying the one specified in the issue. |
/lgtm |
@camilamacedo86 @estroz The changes lgtm |
This PR changes the manager pod template's security context
runAsUser: 65532
torunAsNonRoot: true
. User 65532 is already specified in a project's Dockerfile which the security context uses whenrunAsUser
is unset, making the security context's value redundant (and prone to drift if that value is changed in the Dockerfile) in kubebuilder's case.Signed-off-by: Eric Stroczynski [email protected]