Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native-deb* targets for zloop workflow #14303

Closed
wants to merge 1 commit into from

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

The zloop workflow is failing in the CI due to an issue detecting the python version when using the rpm/alien packaging. The native Debian packaging doesn't encounter this issue, and arguably the zloop workflow should be using it anyway, so we update the workflow accordingly. This does not resolve the underlying python detection issue but should sort out the zloop worker.

 checking for python3.10... /usr/bin/python3
Traceback (most recent call last):
  File "<stdin>", line 10, in <module>
  File "<string>", line 1, in <module>
AttributeError: module 'packaging.version' has no attribute 'LegacyVersion'
configure: error: "Python >= '3.6.0' development library is not installed"
checking for a version of Python >= '2.1.0'... no

error: Bad exit status from /tmp/zfs-build-runner-RBKDjMjj/TMP/rpm-tmp.DvuEmm (%build)
    Bad exit status from /tmp/zfs-build-runner-RBKDjMjj/TMP/rpm-tmp.DvuEmm (%build)
make[1]: *** [Makefile:13966: rpm-common] Error 1
make: *** [Makefile:13925: rpm-utils-initramfs] Error 2
make: *** Waiting for unfinished jobs....

Description

The zloop workflow always requests an Ubuntu worker. Since we now have native Debian style packaging use these targets for the zloop workflow. This follows up on the work done in #14265.

How Has This Been Tested?

Pending verification by the CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 20, 2022
The zloop workflow always requests an Ubuntu worker.  Since we
now have native Debian style packaging use these targets for
the zloop workflow.  This follows up on the work done in openzfs#14265.

Additionally, rollback to using the ubuntu-20.04 builder until
the ax_python_dev.m4 LegacyVersion build issue with 22.04 has
been resolved.

Signed-off-by: Brian Behlendorf <[email protected]>
@ghost
Copy link

ghost commented Dec 23, 2022

@usaleem-ix any ideas how to fix this?

@usaleem-ix
Copy link
Contributor

@usaleem-ix any ideas how to fix this?

@freqlabs zloop is failing here because LegacyVersion in python was removed recently. There is a PR (#14297) open to address this issue.

Apparently, this issue does not happen in other workflows where native-deb targets are built because we get rid of unnecessary files to create some extra space before installing the dependencies. If same thing is done here for zloop, that should work around this issue. However, pyhton LegacyVersion error should be fixed as well.

@behlendorf behlendorf closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants