Add native-deb* targets to build native Debian packages #14265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmelikov
reviewed
Dec 5, 2022
| python3-cffi | ||
| python3-dev | ||
| python3-packaging | ||
| python3-pip | ||
| python3-setuptools | ||
| python3-sphinx |
There was a problem hiding this comment.
Why do we need this package? IIRC we don't have anything in main repository to use Sphinx on
There was a problem hiding this comment.
This is a dependency mentioned in contrib/debian/control. In contrib/debian/rules.in, sphinx docs can be generated. I think that requires this package.
gmelikov
reviewed
Dec 5, 2022
| @@ -131,5 +131,4 @@ usr/share/man/man8/zstreamdump.8 | |||
| usr/share/man/man4/spl.4 | |||
| usr/share/man/man4/zfs.4 | |||
| usr/share/man/man7/zpool-features.7 | |||
| usr/share/man/man7/dracut.zfs.7 | |||
There was a problem hiding this comment.
Looks like it is valid man page, what's the reason not to install it?
There was a problem hiding this comment.
We have a separate package for dracut, i.e. openzfs-zfs-dracut . The man page is present and installed from there.
By mistake, this was included in openzfs-zfsutils package last time.
ghost
reviewed
Dec 6, 2022
ghost
reviewed
Dec 6, 2022
In continuation of previous openzfs#13451, this commits adds native-deb* targets for make to build native debian packages. Github workflows are updated to build and test native Debian packages. Native packages only build with pre-configured paths (see the dh_auto_configure section in contrib/debian/rules.in). While building native packages, paths should not be configured. Initial config flags e.g. '--enable-debug' are replaced in contrib/debian/rules.in. Additional packages on top of existing zfs packages required to build native packages include debhelper-compat, dh-python, dkms, po-debconf, python3-all-dev, python3-sphinx. Signed-off-by: Umer Saleem <[email protected]>
usaleem-ix
force-pushed
the
NAS-116639
branch
from
1aa3df3 to
3fcd420
Compare
ghost
approved these changes
Dec 6, 2022
behlendorf
approved these changes
Dec 9, 2022
ghost
deleted the
usaleem-ix
added a commit
to truenas/zfs
that referenced
this pull request
Dec 14, 2022
In continuation of previous openzfs#13451, this commits adds native-deb* targets for make to build native debian packages. Github workflows are updated to build and test native Debian packages. Native packages only build with pre-configured paths (see the dh_auto_configure section in contrib/debian/rules.in). While building native packages, paths should not be configured. Initial config flags e.g. '--enable-debug' are replaced in contrib/debian/rules.in. Additional packages on top of existing zfs packages required to build native packages include debhelper-compat, dh-python, dkms, po-debconf, python3-all-dev, python3-sphinx. Reviewed-by: George Melikov <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Umer Saleem <[email protected]> Closes openzfs#14265
usaleem-ix
added a commit
to truenas/zfs
that referenced
this pull request
Dec 17, 2022
In continuation of previous openzfs#13451, this commits adds native-deb* targets for make to build native debian packages. Github workflows are updated to build and test native Debian packages. Native packages only build with pre-configured paths (see the dh_auto_configure section in contrib/debian/rules.in). While building native packages, paths should not be configured. Initial config flags e.g. '--enable-debug' are replaced in contrib/debian/rules.in. Additional packages on top of existing zfs packages required to build native packages include debhelper-compat, dh-python, dkms, po-debconf, python3-all-dev, python3-sphinx. Reviewed-by: George Melikov <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Umer Saleem <[email protected]> Closes openzfs#14265
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Dec 17, 2022
In continuation of previous openzfs#13451, this commits adds native-deb* targets for make to build native debian packages. Github workflows are updated to build and test native Debian packages. Native packages only build with pre-configured paths (see the dh_auto_configure section in contrib/debian/rules.in). While building native packages, paths should not be configured. Initial config flags e.g. '--enable-debug' are replaced in contrib/debian/rules.in. Additional packages on top of existing zfs packages required to build native packages include debhelper-compat, dh-python, dkms, po-debconf, python3-all-dev, python3-sphinx. Reviewed-by: George Melikov <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Umer Saleem <[email protected]> Closes openzfs#14265
behlendorf
added a commit
to behlendorf/zfs
that referenced
this pull request
Dec 20, 2022
The zloop workflow always requests an Ubuntu worker. Since we now have native Debian style packaging use these targets for the zloop workflow. This follows up on the work done in openzfs#14265. Signed-off-by: Brian Behlendorf <[email protected]>
13 tasks
behlendorf
added a commit
to behlendorf/zfs
that referenced
this pull request
Dec 20, 2022
The zloop workflow always requests an Ubuntu worker. Since we now have native Debian style packaging use these targets for the zloop workflow. This follows up on the work done in openzfs#14265. Additionally, rollback to using the ubuntu-20.04 builder until the ax_python_dev.m4 LegacyVersion build issue with 22.04 has been resolved. Signed-off-by: Brian Behlendorf <[email protected]>
usaleem-ix
added a commit
to truenas/zfs
that referenced
this pull request
Dec 22, 2022
In continuation of previous openzfs#13451, this commits adds native-deb* targets for make to build native debian packages. Github workflows are updated to build and test native Debian packages. Native packages only build with pre-configured paths (see the dh_auto_configure section in contrib/debian/rules.in). While building native packages, paths should not be configured. Initial config flags e.g. '--enable-debug' are replaced in contrib/debian/rules.in. Additional packages on top of existing zfs packages required to build native packages include debhelper-compat, dh-python, dkms, po-debconf, python3-all-dev, python3-sphinx. Reviewed-by: George Melikov <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Umer Saleem <[email protected]> Closes openzfs#14265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In continuation of previous #13451, make targets are added to build
native Debian packages. GitHub workflows are also updated to build
and test native Debian packages.
Description
This commit adds make targets to build native Debian packages and
updates the GitHub workflows to exercise the native packages.
Native packages only build with pre-configured paths (see the
dh_auto_configure section in contrib/debian/rules.in). While building
native packages, paths should not be configured. Initial config flags
e.g. '--enable-debug' are replaced in contrib/debian/rules.in.
Additional packages on top of existing zfs packages required to build
native packages include debhelper-compat, dh-python, dkms,
po-debconf, python3-all-dev and python3-sphinx.
For release, contrib/debian/changelog should be updated with a new
entry for the release.
How Has This Been Tested?
Lots of ZTS runs via GitHub workflows and on Debian 11.
Types of changes
Checklist:
Signed-off-by.