Skip to content

[ROCm] Build fix #11398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ekuznetsov139 wants to merge 2 commits into from
Closed

[ROCm] Build fix #11398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cdd25c
Build fix
ekuznetsov139 Apr 10, 2024
b86d12f
Workaround for static_assert needed for some compilers
ekuznetsov139 Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xla/stream_executor/rocm/rocm_executor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ dnn::DnnSupport* GpuExecutor::AsDnn() {
}
PluginRegistry* registry = PluginRegistry::Instance();
absl::StatusOr<PluginRegistry::DnnFactory> status =
registry->GetFactory<PluginRegistry::DnnFactory>(cuda::kCudaPlatformId);
registry->GetFactory<PluginRegistry::DnnFactory>(rocm::kROCmPlatformId);
if (!status.ok()) {
LOG(ERROR) << "Unable to retrieve DNN factory: "
<< status.status().message();
Expand Down
5 changes: 4 additions & 1 deletion xla/tests/complex_unary_op_samples.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ limitations under the License.

namespace complex_unary_op_samples {

template<class>
constexpr bool dependent_false = false;

template <typename T, int default_dps_deficiency = 0>
struct Log1p {
typedef std::complex<T> InputType;
Expand Down Expand Up @@ -1438,7 +1441,7 @@ struct Log1p {
/* 288 */ {{inf, inf}, {inf, pi_4}, 1.e+00}};
return table;
} else {
static_assert(false); /* unreachable */
static_assert(dependent_false<T>); /* unreachable */
}
}
};
Expand Down
5 changes: 4 additions & 1 deletion xla/tests/complex_unary_op_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ limitations under the License.
namespace xla {
namespace {

template<class>
constexpr bool dependent_false = false;

class ComplexUnaryOpTest : public ClientLibraryTestBase {
protected:
template <typename T, size_t index, typename... Types>
Expand Down Expand Up @@ -64,7 +67,7 @@ class ComplexUnaryOpTest : public ClientLibraryTestBase {
} else if constexpr (std::is_same_v<FloatType, double>) {
atol = std::ldexp(1e-15f, precision_deficiency);
} else {
static_assert(false); // unreachable
static_assert(dependent_false<FloatType>);
}

XlaBuilder builder(TestName());
Expand Down