Closed
Conversation
Member
|
It looks like in addition to the build fix, there is one more commit in this PR that depends on another PR. Can you please send the independent build fixes (i.e. commit 2 and 3) as one PR? |
ekuznetsov139
force-pushed
the
ci_rocm_fix_240410
branch
from
0d62095 to
b86d12f
Compare
akuegel
approved these changes
Apr 10, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
Imported from GitHub PR openxla/xla#11398 This contains two fixes: * A compilation fix for stream_executor/rocm/rocm_executor.cc after it got broken by the commit openxla/xla@3c5cf0a * A workaround that allows static_assert(false) to be compiled with compilers not implementing https://cplusplus.github.io/CWG/issues/2518.html Copybara import of the project: -- 5cdd25c3190140fec619073d25a20952fed2fd8b by Eugene Kuznetsov <eugene.kuznetsov@amd.com>: Build fix -- b86d12ff02a2a6247a7f991f77dfdafb08a79703 by Eugene Kuznetsov <eugene.kuznetsov@amd.com>: Workaround for static_assert needed for some compilers (https://cplusplus.github.io/CWG/issues/2518.html) Merging this change closes #11398 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11398 from ROCm:ci_rocm_fix_240410 b86d12ff02a2a6247a7f991f77dfdafb08a79703 PiperOrigin-RevId: 623449405
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
Imported from GitHub PR openxla/xla#11398 This contains two fixes: * A compilation fix for stream_executor/rocm/rocm_executor.cc after it got broken by the commit openxla/xla@3c5cf0a * A workaround that allows static_assert(false) to be compiled with compilers not implementing https://cplusplus.github.io/CWG/issues/2518.html Copybara import of the project: -- 5cdd25c3190140fec619073d25a20952fed2fd8b by Eugene Kuznetsov <eugene.kuznetsov@amd.com>: Build fix -- b86d12ff02a2a6247a7f991f77dfdafb08a79703 by Eugene Kuznetsov <eugene.kuznetsov@amd.com>: Workaround for static_assert needed for some compilers (https://cplusplus.github.io/CWG/issues/2518.html) Merging this change closes #11398 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11398 from ROCm:ci_rocm_fix_240410 b86d12ff02a2a6247a7f991f77dfdafb08a79703 PiperOrigin-RevId: 623449405
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11398 from ROCm:ci_rocm_fix_240410 b86d12ff02a2a6247a7f991f77dfdafb08a79703 PiperOrigin-RevId: 622331861
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11398 from ROCm:ci_rocm_fix_240410 b86d12ff02a2a6247a7f991f77dfdafb08a79703 PiperOrigin-RevId: 621898587
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
Imported from GitHub PR openxla/xla#11398 This contains two fixes: * A compilation fix for stream_executor/rocm/rocm_executor.cc after it got broken by the commit openxla/xla@3c5cf0a * A workaround that allows static_assert(false) to be compiled with compilers not implementing https://cplusplus.github.io/CWG/issues/2518.html Copybara import of the project: -- 5cdd25c3190140fec619073d25a20952fed2fd8b by Eugene Kuznetsov <eugene.kuznetsov@amd.com>: Build fix -- b86d12ff02a2a6247a7f991f77dfdafb08a79703 by Eugene Kuznetsov <eugene.kuznetsov@amd.com>: Workaround for static_assert needed for some compilers (https://cplusplus.github.io/CWG/issues/2518.html) Merging this change closes #11398 PiperOrigin-RevId: 623471087
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11398 from ROCm:ci_rocm_fix_240410 b86d12ff02a2a6247a7f991f77dfdafb08a79703 PiperOrigin-RevId: 616889174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains two fixes: