Skip to content

[ROCm] Fix compilation issues related to aa08925e2dd1351c68e7838e074fe35908e3#11331

Closed
zoranjovanovic-ns wants to merge 1 commit intoopenxla:mainfrom
ROCm:rocm_triton_fix_1
Closed

[ROCm] Fix compilation issues related to aa08925e2dd1351c68e7838e074fe35908e3#11331
zoranjovanovic-ns wants to merge 1 commit intoopenxla:mainfrom
ROCm:rocm_triton_fix_1

Conversation

@zoranjovanovic-ns
Copy link
Contributor

@zoranjovanovic-ns zoranjovanovic-ns commented Apr 8, 2024

No description provided.

@zoranjovanovic-ns zoranjovanovic-ns marked this pull request as draft April 8, 2024 20:55
@zoranjovanovic-ns
Copy link
Contributor Author

Temporarily remove ROCm Triton specific passes and include files until ROCm Triton is
not included in build.

(Triton in XLA for ROCm - ir_emitter_triton related changes)
@zoranjovanovic-ns zoranjovanovic-ns marked this pull request as ready for review April 9, 2024 14:58
@zoranjovanovic-ns zoranjovanovic-ns changed the title Fix compilation issues related to aa08925e2dd1351c68e7838e074fe35908e3… [ROCm] Fix compilation issues related to aa08925e2dd1351c68e7838e074fe35908e3 Apr 9, 2024
@ekuznetsov139 ekuznetsov139 mentioned this pull request Apr 10, 2024
@i-chaochen
Copy link
Contributor

Hi @xla-rotation could you help us to review and merge this, please? as it's a missing caused by COPYBARA during aa08925 is merged

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Apr 10, 2024
…8e7838e074fe35908e3

Imported from GitHub PR openxla/xla#11331

Copybara import of the project:

--
a4f80a3f32a10230bfdaa1dadc12f1f385883d8a by Zoran Jovanovic <zjovanov@amd.com>:

Fix compilatio issues related to aa08925e2dd1351c68e7838e074fe35908e3ea07
(Triton in XLA for ROCm - ir_emitter_triton related changes)

Merging this change closes #11331

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11331 from ROCm:rocm_triton_fix_1 a4f80a3f32a10230bfdaa1dadc12f1f385883d8a
PiperOrigin-RevId: 623459791
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Apr 10, 2024
…8e7838e074fe35908e3

Imported from GitHub PR openxla/xla#11331

Copybara import of the project:

--
a4f80a3f32a10230bfdaa1dadc12f1f385883d8a by Zoran Jovanovic <zjovanov@amd.com>:

Fix compilatio issues related to aa08925e2dd1351c68e7838e074fe35908e3ea07
(Triton in XLA for ROCm - ir_emitter_triton related changes)

Merging this change closes #11331

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11331 from ROCm:rocm_triton_fix_1 a4f80a3f32a10230bfdaa1dadc12f1f385883d8a
PiperOrigin-RevId: 623459791
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Apr 10, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11331 from ROCm:rocm_triton_fix_1 a4f80a3f32a10230bfdaa1dadc12f1f385883d8a
PiperOrigin-RevId: 619652340
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Apr 10, 2024
This was added as part of a prototype but no users appear to exist any more, and it was never a publicized API.

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11331 from ROCm:rocm_triton_fix_1 a4f80a3f32a10230bfdaa1dadc12f1f385883d8a
PiperOrigin-RevId: 623274894
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Apr 10, 2024
…8e7838e074fe35908e3

Imported from GitHub PR openxla/xla#11331

Copybara import of the project:

--
a4f80a3f32a10230bfdaa1dadc12f1f385883d8a by Zoran Jovanovic <zjovanov@amd.com>:

Fix compilatio issues related to aa08925e2dd1351c68e7838e074fe35908e3ea07
(Triton in XLA for ROCm - ir_emitter_triton related changes)

Merging this change closes #11331

PiperOrigin-RevId: 623476962
@alekstheod alekstheod deleted the rocm_triton_fix_1 branch July 3, 2025 08:11
@alekstheod alekstheod restored the rocm_triton_fix_1 branch July 15, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants