Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU][ARM64] Added Greater JIT emitter (#24421) #25046

Closed
wants to merge 12 commits into from
Closed

[CPU][ARM64] Added Greater JIT emitter (#24421) #25046

wants to merge 12 commits into from

Conversation

jvr0123
Copy link
Contributor

@jvr0123 jvr0123 commented Jun 16, 2024 •
edited by ilya-lavrenov
Loading

Details:

  • Implemented Greater jit emitter
  • Added relevant unit test

Tickets:

@jvr0123 jvr0123 requested review from a team as code owners June 16, 2024 00:58
@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: CPU OpenVINO CPU plugin labels Jun 16, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Jun 16, 2024
@jvr0123 jvr0123 changed the title [CPU][ARM64] Added LogicalNot JIT emitter (#24421) [CPU][ARM64] Added Greater JIT emitter (#24421) Jun 16, 2024
@jvr0123
[CPU][ARM64] Added Greater JIT emitter (openvinotoolkit#24421)
65778f6 
Added support and unit test for Greater jit emitter
@jvr0123 jvr0123 force-pushed the cpu-eltwise-arm-greater branch from 48ccbd1 to 65778f6 Compare June 16, 2024 01:04
@jvr0123
Copy link
Contributor Author

jvr0123 commented Jun 17, 2024

I'm somewhat confused by some of the checks failing. I'm currently running ./bin/aarch64/Debug/ov_cpu_func_tests --gtest_filter="*smoke*Type=Greater*" and only getting passes. Is there a different test that should be ran and that is failing?

@jvr0123
Copy link
Contributor Author

jvr0123 commented Jun 27, 2024

@eshoguli gentle reminder this PR is still open. Any feedback on the general approach?

eshoguli
eshoguli reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@eshoguli eshoguli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
Can you, please, update ActivationLayerCPUTest::generate_inputs to cover Greater emitter functionality. There is an example for Sign activation. You can do something similar but use more then one value, please:

  1. Two input tensor values should be different: less, equal and greater.
  2. Please, update to have special values: negative zero, NaN (several values), Infinity values, ... in test input tensor.

src/plugins/intel_cpu/src/nodes/kernels/aarch64/jit_uni_eltwise_generic.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jul 25, 2024
@mg-intel mg-intel removed the Stale label Jul 25, 2024
@dmitry-gorokhov
Copy link
Contributor

build_jenkins

@dmitry-gorokhov
Copy link
Contributor

build_jenkins

@dmitry-gorokhov dmitry-gorokhov added this to the 2024.5 milestone Aug 30, 2024
@dmitry-gorokhov
Copy link
Contributor

Hey @jvr0123! I see some Ci failures caused by this PR. Could you please fix them?

@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Sep 14, 2024
@mlukasze
Copy link
Contributor

hey @jvr0123 please update a status of the PR - will you have time to finish it?

@github-actions github-actions bot removed the Stale label Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Oct 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshoguli eshoguli eshoguli left review comments

Assignees

@eshoguli eshoguli

Labels
category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common ExternalPR External contributor Stale
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for Greater operation
6 participants
@jvr0123 @dmitry-gorokhov @mlukasze @eshoguli @sys-openvino-ci @mg-intel