Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for Greater operation #24421

Closed
eshoguli opened this issue May 8, 2024 · 6 comments · Fixed by #27145
Closed

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for Greater operation #24421

eshoguli opened this issue May 8, 2024 · 6 comments · Fixed by #27145
Assignees
@nashez
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers no_stale Do not mark as stale platform: arm OpenVINO on ARM / ARM64
Milestone
2024.5

Comments

@eshoguli
Copy link
Contributor

eshoguli commented May 8, 2024

Context

JIT Emitters are part of code generation feature (a.k.a. tensor compiler) that automatically produces highly-efficient optimized fused subgraph binary code. Each emitter implements specific operation from low level OpenVINO dialect.

Prerequisites

Recommended to use ARM CPU based platform for development (e.g. Mac, Raspberry Pi etc). Emulators (e.g. QEMU) is still an option, but not that convenient, especially for final performance evaluation.

What needs to be done?

Before emitter implementation, please, modify tests to be sure that deveoped functionality is covered by test:

Tests

Tests are disabled in default build, so ensure to add -DENABLE_TESTS=ON into cmake command.

GoogleTest is used for testing. CPU functional test target is ov_cpu_func_tests. You can use two GoogleTest filters for element-wise and activation operations:

  • for element-wise operations:
./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Eltwise*"
  • for activations:
./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Activation*"

Example Pull Requests

Resources

Contact points

@eshoguli, @dmitry-gorokhov

Ticket

CVS-140694
@eshoguli eshoguli added good first issue Good for newcomers no_stale Do not mark as stale labels May 8, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues May 8, 2024
@eshoguli eshoguli added category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels May 8, 2024
@winstonallo
Copy link

.take

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Jun 6, 2024
@winstonallo winstonallo removed their assignment Jun 6, 2024
@jvr0123
Copy link
Contributor

jvr0123 commented Jun 9, 2024

.take

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

jvr0123 added a commit to jvr0123/openvino that referenced this issue Jun 16, 2024
@jvr0123
[CPU][ARM64] Added LogicalNot JIT emitter (openvinotoolkit#24421)
48ccbd1 
Added support and unit test for Greater jit emitter
@jvr0123 jvr0123 mentioned this issue Jun 16, 2024
Closed
jvr0123 added a commit to jvr0123/openvino that referenced this issue Jun 16, 2024
@jvr0123
[CPU][ARM64] Added Greater JIT emitter (openvinotoolkit#24421)
65778f6 
Added support and unit test for Greater jit emitter
@dmitry-gorokhov dmitry-gorokhov moved this from Assigned to In Review in Good first issues Jul 9, 2024
@mlukasze mlukasze moved this from In Review to Contributors Needed in Good first issues Oct 11, 2024
@nashez
Copy link
Contributor

nashez commented Oct 15, 2024

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Oct 15, 2024
nashez added a commit to nashez/openvino that referenced this issue Oct 19, 2024
@nashez
[CPU][ARM64] Add JIT emitter for Eltwise Greater operation
e388e33 
* Added a jit_greater_emitter derived class in
  aarch64/jit_eltwise_emitters
* Created entry Algorithm::EltwiseGreater in the
  get_supported_precisions in nodes/kernels/aarch64
* Add the EltwiseGreater entry in the aarch64
  executors supported algorithms

Closes: openvinotoolkit#24421

Signed-off-by: Nashez Zubair <[email protected]>
@nashez nashez mentioned this issue Oct 19, 2024
Merged
nashez added a commit to nashez/openvino that referenced this issue Oct 20, 2024
@nashez
[CPU][ARM64] Add JIT emitter for Eltwise Greater operation
4119b4f 
* Added a jit_greater_emitter derived class in
  aarch64/jit_eltwise_emitters
* Created entry Algorithm::EltwiseGreater in the
  get_supported_precisions in nodes/kernels/aarch64
* Add the EltwiseGreater entry in the aarch64
  executors supported algorithms

Closes: openvinotoolkit#24421

Signed-off-by: Nashez Zubair <[email protected]>
nashez added a commit to nashez/openvino that referenced this issue Oct 21, 2024
@nashez
[CPU][ARM64] Add JIT emitter for Eltwise Greater operation
5e4954d 
* Added a jit_greater_emitter derived class in
  aarch64/jit_eltwise_emitters
* Created entry Algorithm::EltwiseGreater in the
  get_supported_precisions in nodes/kernels/aarch64
* Add the EltwiseGreater entry in the aarch64
  executors supported algorithms

Closes: openvinotoolkit#24421

Signed-off-by: Nashez Zubair <[email protected]>
nashez added a commit to nashez/openvino that referenced this issue Oct 23, 2024
@nashez
[CPU][ARM64] Add JIT emitter for Eltwise Greater operation
a46a3af 
* Added a jit_greater_emitter derived class in
  aarch64/jit_eltwise_emitters
* Created entry Algorithm::EltwiseGreater in the
  get_supported_precisions in nodes/kernels/aarch64
* Add the EltwiseGreater entry in the aarch64
  executors supported algorithms

Closes: openvinotoolkit#24421

Signed-off-by: Nashez Zubair <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Oct 25, 2024
@nashez
[CPU][ARM64] Add JIT emitter for Eltwise Greater operation (#27145)
e19724e 
### Details:
- Added a jit_greater_emitter derived class in
aarch64/jit_eltwise_emitters
- Created entry Algorithm::EltwiseGreater in the
get_supported_precisions in nodes/kernels/aarch64
- Add the EltwiseGreater entry in the aarch64 executors supported
algorithms

### Tickets:
- Closes: #24421

Signed-off-by: Nashez Zubair <[email protected]>
@github-project-automation github-project-automation bot moved this from Assigned to Closed in Good first issues Oct 25, 2024
@mlukasze mlukasze added this to the 2024.5 milestone Oct 25, 2024
CuriousPanCake pushed a commit to CuriousPanCake/openvino that referenced this issue Nov 6, 2024
@nashez @CuriousPanCake
[CPU][ARM64] Add JIT emitter for Eltwise Greater operation (openvinot…
b13061c 
…oolkit#27145)

### Details:
- Added a jit_greater_emitter derived class in
aarch64/jit_eltwise_emitters
- Created entry Algorithm::EltwiseGreater in the
get_supported_precisions in nodes/kernels/aarch64
- Add the EltwiseGreater entry in the aarch64 executors supported
algorithms

### Tickets:
- Closes: openvinotoolkit#24421

Signed-off-by: Nashez Zubair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nashez nashez

Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers no_stale Do not mark as stale platform: arm OpenVINO on ARM / ARM64
Projects
Good first issues
Archived in project
Milestone
2024.5
5 participants
@jvr0123 @nashez @mlukasze @eshoguli @winstonallo