Update mxnet requirement from ~=1.2.0 to ~=1.9.1 in /tools/mo #15018
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [mxnet](https://github.com/apache/incubator-mxnet) to permit the latest version. - [Release notes](https://github.com/apache/incubator-mxnet/releases) - [Changelog](https://github.com/apache/mxnet/blob/master/NEWS.md) - [Commits](apache/mxnet@1.2.0...1.9.1) --- updated-dependencies: - dependency-name: mxnet dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
category: dependency_changes
dependabot
bot
requested review from
eaidova and
artanokhov
and removed request for
a team
Co-authored-by: Roman Kazantsev <[email protected]>
|
@ilya-lavrenov, could you please rebase PR? something wrong happens with CI:( |
github-actions
bot
added
category: tools
done, please, check once again. |
…ols/mo/mxnet-approx-eq-1.9.1
|
@p-wysocki we have pip-conflicts here. Could you please resolve? |
|
The pip-conflicts logs look a bit weird, it looks like a lot of packages are being downloaded and Can we merge master again, just in case? IMO it looks like test infra commit hasn't been updated in this PR. |
|
Looks like we still have pip conflicts on Windows. |
There was a problem hiding this comment.
As mxnet have upper bound on numpy:
67467f8 [v1.9.x] [BUGFIX] Upgrade numpy to <1.20.0 to avoid security vulnerabilities ...
and this results in building from source (which fails only for Python 3.11):
setup.py:67: RuntimeWarning: NumPy 1.19.4 may not yet support Python 3.11.
ERROR: Task 'install 3.11_pip_23.0.1 py reqs and check conflicts'
Two resolutions:
- bump/fix mxnet (which seems impossible due to 1.9.1 being the latest version)
- find solution and adjust pipelines to build numpy correctly on specific platforms
@p-wysocki what do you think?
PS what worries me on Win-based platforms:
Using cached mxnet-1.7.0.post2-py2.py3-none-win_amd64.whl (33.1 MB)
|
On linux As @jiwaszki mentioned, on failing Windows:
I think that we should try removing pip cache on Windows platforms and see what happens then. |
If we look at pypi, we don't see mxnet for Windows for latest versions. |
|
It seems
It hasn't had a release in over a year (https://github.com/apache/mxnet/releases) and overall seems unmaintained. I think that we in order to merge to PR, if it's even possible, we'd have to do some major hacks. I'm in favor of closing it and starting some discussions on supporting |
We already have agreed to remove mxnet support (as well as Kaldi and Caffe) in 2024.0 |
That's great, I didn't know. I'm closing this PR because according to the links there's no support for Windows in newer packages, so it has to stay that way until deprecation. Please reopen if needed. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on mxnet to permit the latest version.
Release notes
Sourced from mxnet's releases.
Changelog
Sourced from mxnet's changelog.
... (truncated)
Commits
3f8f3be[1.9.x] Update version for 1.9.1 release (#21003)718dde9[v1.9.x][submodule] Upgrade oneDNN to the top of rls-v2.4 branch (#20994)cfbcfb1revert cleanup stream (#20998)32b65a2[v1.9.x] Fix css for Apache links, add to Python docs. (#20995)f5a25b4[v1.9.x] Update website footer to include required Apache links (#20993)76fc3efPort BRGEMM (#20910)67467f8[v1.9.x] [BUGFIX] Upgrade numpy to <1.20.0 to avoid security vulnerabilities ...3a08242quantized elemwise mul changed out type to float (#20926)32cef8eAvoid modifying loaded library map while iterating in lib_close() (#20941) (#...0c5b5b1[v1.9.x] Port #20889 from v1.x (#20923)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)