Repository navigation
UCT/GDAKI: Include only usable IB HCAs in GDA matrix - v1.23.x. - #12074
Conversation
* UCT/GDAKI: Include only usable IB HCAs in GDA matrix. * UCT/GDAKI: Improve debug logging and return code. * UCT/GDAKI: Apply review comments. * UCT/GDAKI: Apply review comment. * UCT/GDAKI: Include only usable IB HCAs in GDA matrix. - 2 --------- Co-authored-by: Artemy Kovalyov <artemyko@nvidia.com>
|
🤖 Starting review — findings will be posted here when done. |
| for (score_index = 0; score_index < num_sys_active_ibdevs; | ||
| score_index++) { | ||
| ibdesc = &dmat[scores[score_index].ibdev_index]; | ||
| scores[score_index].reachable = ucs_topo_is_reachable( |
There was a problem hiding this comment.
ucs_topo_sys_device_enable_aux_path() breaks on the first matching DEV, so each GPU records only one data-direct sibling. On a node where two data-direct HCAs sit under the same PCIe switch as the GPUs, every HCA except that one sibling becomes unreachable for all GPUs, ends up with cuda_map == 0, and stops exposing GDA devices at all (so e.g. GDA_MAX_HCA_PER_GPU=2 is silently reduced to 1, and uct_gdaki_fill_cuda_tl_devices() returns UCS_ERR_NO_DEVICE for an otherwise usable HCA). Pre-patch both NICs were candidates. Is that intended, or should the filter apply only when the HCA's aux device is on a different switch than the GPU?
|
Residual coverage gap: no test accompanies the change. The three behavior changes (inactive-port skip, |
|
🤖 CI Triage Agent — TL;DR: The "AddressSanitizer roce on worker 0" job never ran any UCX code — the Azure Pipelines agent Full analysisSummary: Job Root cause: Infrastructure/agent failure, not a product defect. Timeline from the fetched log:
Total job runtime was ~5 seconds with no gaps in the timestamps, so there was no hang and no timeout — the agent process/service was stopped out from under the job (agent restart, host maintenance/reboot, or OOM-kill of the agent service on Implicated commit: unknown — no UCX commit is implicated; the failure predates any code execution (candidate commit File: N/A — failure occurred in the Azure Pipelines agent ("Initialize containers" step, agent Suggested fix:
Related: PR #12074 (the PR under test — not the cause); no existing UCX issue tracks this agent-shutdown signature. Issue search for the error string returned only unrelated PRs (#11932, #12033, #11903, #11870, #11923).
|
What?
backport #11727