Repository navigation
CI: Do not start PR pipelines for draft pull requests - #11932
Conversation
f7e1080 to
1738893
Compare
|
🤖 Starting review — findings will be posted here when done. |
|
Coverage gap: per |
1738893 to
ed21502
Compare
|
/azp run UCX PR |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
🤖 Starting review — findings will be posted here when done. |
Marking a draft PR "ready for review" makes Azure queue a second run of the same commit and auto-cancel the run already in progress. Over the last 30 days this happened 26 times, 17 of them killing a running draft build (one after 18 hours in the test queue). Azure has no option to build drafts and skip that transition, so stop building drafts instead: a draft gets its first PR pipeline run when it is marked ready. Only the PR pipeline is gated. The snapshot and release pipelines do real work on a PR only when asked via an "AZP/SNAPSHOT: " or "AZP/RELEASE: " commit title, which is how packaging changes get tested from draft PRs; their unrequested runs cost seconds, so they stay as is. Checked on this PR: pushes while draft queued no UCX PR run, an "/azp run UCX PR" comment on the draft was refused by Azure, and marking the PR ready queued the run. Signed-off-by: Alexey Rivkin <arivkin@nvidia.com>
ed21502 to
706a164
Compare
|
🤖 Starting review — findings will be posted here when done. |
|
🤖 CI Triage Agent — TL;DR: The AddressSanitizer "roce on worker 0" job was killed mid-compile by an Azure DevOps agent shutdown ("The agent has received a shutdown signal" → "The operation was canceled"), not by any UCX code/test failure — simply re-run the pipeline. Full analysisSummary: Job Root cause: Infrastructure-level cancellation, not a code defect. The log shows continuous, healthy build progress — object files completing every 1–15 s from 14:20:04 through 14:28:28 (largest gap ≈ 30 s, between 14:22:26 and 14:22:45), so nothing hung and nothing hit a wall-clock timeout. At 14:28:23 the agent emitted Implicated commit: none — build was not failed by code. Branch head is [REDACTED:Hex High Entropy String] (Alexey Rivkin), which only edits the PR trigger. File: buildlib/azure-pipelines-pr.yml:4-6 (only the PR-trigger change under test; no source file implicated in the abort) Suggested fix: Re-queue the PR pipeline (or push an empty commit) — this is a transient agent loss. If it recurs on the same agent, ask CI ops to check the health/drain schedule of the self-hosted pool hosting the Related: PR #11932 (this PR,
|
What?
Do not start CI for draft PRs.
Why?
Azure behaviour change - now marking a draft PR "ready for review" makes Azure queue a second run of the same commit. This causes extra full runs, adding load to already strained resources.
Microsoft has no fix planned (https://developercommunity.visualstudio.com/t/11032682).
How?
buildlib/azure-pipelines-pr.yml:drafts: falsein thepr:block. One line.