Repository navigation
UCT/D2P: Multi-channel support with per-EP DPA address and RING_DB flag - #11701
Merged
Merged
Conversation
Replace qp_idx with ep_dpa_addr in descriptor so the DPA poster can locate the per-channel QP from the EP's DPA heap base plus channel index. Add UCT_IB_D2P_FLAG_RING_DB so the GPU controls doorbell ringing per-op based on UCT_DEVICE_FLAG_NODELAY. Split gpu_ep into per-channel and per-EP structs; pass channel_id through the device API dispatch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ofirfarjun7
reviewed
Aug 2, 2026
| 0, comp == nullptr ? 0 : UCT_IB_D2P_FLAG_CQ_UPDATE); | ||
| uint16_t desc_flags = (comp != nullptr ? UCT_IB_D2P_FLAG_CQ_UPDATE : 0) | | ||
| (flags & UCT_DEVICE_FLAG_NODELAY ? | ||
| UCT_IB_D2P_FLAG_RING_DB : |
Contributor
There was a problem hiding this comment.
NEXT PR: Maybe we can remove this translation and just use UCT_DEVICE_FLAG_NODELAY?
ofirfarjun7
reviewed
Aug 2, 2026
|
|
||
| desc->opcode = opcode; | ||
| desc->length = length; | ||
| desc->ep_idx = ep->ep_idx; |
Contributor
There was a problem hiding this comment.
NEXT PR: ep_idx confused me, maybe we can come up with better name?
ofirfarjun7
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace qp_idx with ep_dpa_addr in descriptor so the DPA poster can locate the per-channel QP from the EP's DPA heap base plus channel index. Add UCT_IB_D2P_FLAG_RING_DB so the GPU controls doorbell ringing per-op based on UCT_DEVICE_FLAG_NODELAY. Split gpu_ep into per-channel and per-EP structs; pass channel_id through the device API dispatch.