Repository navigation
UCT/IB/UD: update stale dest ep_id and stale acks from before connection reset - v1.20.x - #11128
Merged
Merged
Conversation
gleon99
previously approved these changes
Jan 20, 2026
yosefe
changed the title
ivanallen
reviewed
Jan 21, 2026
|
|
||
| /* Ignore stale ACKs for unsent packets (e.g., after endpoint reset). | ||
| * Valid ACK PSN must be in (acked_psn, psn). */ | ||
| if (ucs_unlikely(UCT_UD_PSN_COMPARE(ep->tx.psn, <=, ack_psn))) { |
There was a problem hiding this comment.
Hi, @roiedanino
Whether this issue is related to #11107?
Contributor
Author
There was a problem hiding this comment.
Hi, I need to check this, but at first glance, it looks like the same assert failure
roiedanino
force-pushed
the
v1.20.x-ud-ack-fix
branch
from
January 22, 2026 08:32
c91c75b to
8700633
Compare
…ion reset (openucx#11092) * UCT/IB/UD: revise stale ep_id and stale acks from before connection reset * AUTHORS: update * UCT/IB/UD: unify codeline for readability * UCT/IB/UD: unify codeline for readability * TEST/GTEST/UCT/IB: added a test for checking dest ep id is being updated Signed-off-by: Roie Danino <rdanino@nvidia.com> --------- Signed-off-by: Roie Danino <rdanino@nvidia.com> Co-authored-by: Roie Danino <rdanino@nvidia.com> (cherry picked from commit 0a4759c)
roiedanino
force-pushed
the
v1.20.x-ud-ack-fix
branch
from
January 22, 2026 08:35
8700633 to
b7609fe
Compare
Signed-off-by: Roie Danino <rdanino@nvidia.com>
gleon99
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 0a4759c)
What
Porting #11092 fix to v1.20.x
Co-authored with @wehyy