Repository navigation
UCT/IB/UD: update stale dest ep_id and stale acks from before connection reset - #11092
Merged
Merged
Conversation
Contributor
|
Please add |
roiedanino
reviewed
Jan 4, 2026
Contributor
Author
|
Thanks @roiedanino ! |
Signed-off-by: Roie Danino <rdanino@nvidia.com>
roiedanino
approved these changes
Jan 6, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gleon99
approved these changes
Jan 20, 2026
roiedanino
approved these changes
Jan 20, 2026
roiedanino
added a commit
to roiedanino/ucx
that referenced
this pull request
Jan 20, 2026
…ion reset (openucx#11092) * UCT/IB/UD: revise stale ep_id and stale acks from before connection reset * AUTHORS: update * UCT/IB/UD: unify codeline for readability * UCT/IB/UD: unify codeline for readability * TEST/GTEST/UCT/IB: added a test for checking dest ep id is being updated Signed-off-by: Roie Danino <rdanino@nvidia.com> --------- Signed-off-by: Roie Danino <rdanino@nvidia.com> Co-authored-by: Roie Danino <rdanino@nvidia.com> (cherry picked from commit 0a4759c)
roiedanino
added a commit
to roiedanino/ucx
that referenced
this pull request
Jan 22, 2026
…ion reset (openucx#11092) * UCT/IB/UD: revise stale ep_id and stale acks from before connection reset * AUTHORS: update * UCT/IB/UD: unify codeline for readability * UCT/IB/UD: unify codeline for readability * TEST/GTEST/UCT/IB: added a test for checking dest ep id is being updated Signed-off-by: Roie Danino <rdanino@nvidia.com> --------- Signed-off-by: Roie Danino <rdanino@nvidia.com> Co-authored-by: Roie Danino <rdanino@nvidia.com> (cherry picked from commit 0a4759c)
roiedanino
added a commit
to roiedanino/ucx
that referenced
this pull request
Jan 22, 2026
…ion reset (openucx#11092) * UCT/IB/UD: revise stale ep_id and stale acks from before connection reset * AUTHORS: update * UCT/IB/UD: unify codeline for readability * UCT/IB/UD: unify codeline for readability * TEST/GTEST/UCT/IB: added a test for checking dest ep id is being updated Signed-off-by: Roie Danino <rdanino@nvidia.com> --------- Signed-off-by: Roie Danino <rdanino@nvidia.com> Co-authored-by: Roie Danino <rdanino@nvidia.com> (cherry picked from commit 0a4759c)
gleon99
pushed a commit
that referenced
this pull request
Jan 22, 2026
…ion reset - v1.20.x (#11128) * UCT/IB/UD: update stale dest ep_id and stale acks from before connection reset (#11092) * UCT/IB/UD: revise stale ep_id and stale acks from before connection reset * AUTHORS: update * UCT/IB/UD: unify codeline for readability * UCT/IB/UD: unify codeline for readability * TEST/GTEST/UCT/IB: added a test for checking dest ep id is being updated Signed-off-by: Roie Danino <rdanino@nvidia.com> --------- Signed-off-by: Roie Danino <rdanino@nvidia.com> Co-authored-by: Roie Danino <rdanino@nvidia.com> (cherry picked from commit 0a4759c) * AUTHORS: added wehy Signed-off-by: Roie Danino <rdanino@nvidia.com> --------- Signed-off-by: Roie Danino <rdanino@nvidia.com> Co-authored-by: wehy <18174858434@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Ignore stale ACKs from previous connections in UD endpoint ACK processing.
Update the stale dest ep_id in the UD endpoint's CREQ receive processing when a connection is reset.
Why?
After the peer endpoint resets, reusing the same UD QP number by the peer can lead to the reuse of the local UD endpoint in rx_creq, ultimately causing an assertion failure and crash due to mismatched creq->ep_addr.ep_id and ep->dest_ep_id