-
Notifications
You must be signed in to change notification settings - Fork 251
Add new remove_stake_full_limit extrinsic. #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…full_limit # Conflicts: # pallets/subtensor/src/macros/dispatches.rs
…move_stake_full_limit # Conflicts: # pallets/subtensor/src/macros/dispatches.rs
|
I prepared this PR for Bittensor SDK opentensor/bittensor#2897 As I mentioned in the description, my PR is based on both branches:
To make SDK PR workable, it is necessary to merge the 2 mentioned branches and the devnet-ready with the following changes:
Otherwise looks good. Pls keep me updated with changes. |
|
I updated the extrinsic after the offline conversation with @basfroman : I changed the price_limit parameter to optional. |
PR opentensor/bittensor#2897 is ready. I'll wait until your PR is merged to |
basfroman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no objections from the SDK. Everything is working as discussed.
Description
This PR adds a new
remove_stake_full_limitextrinsic. The extrinsic uses the logic ofremove_stake_limitbut withoutpartialand 'unstake_amount' parameters. It removes all stakes from the subnet.Related Issue(s)
unstake_allandunstake_all(orremove_all) #1661Type of Change
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly