fix(db): invalid uuid error message #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedoublev
requested changes
Apr 22, 2024
Contributor
jakedoublev
left a comment
jakedoublev
left a comment
There was a problem hiding this comment.
This is nice cleanup, but it looks like the same error is returned from this wrapper function, db.ErrUUIDInvalid, which reads value not a valid UUID? In that case, it seems like it will still not be clear to the requester that the member id was invalid and not the value id as the original opener of the issue found.
Contributor
Author
|
Server responses are wrapped again with the |
jakedoublev
approved these changes
Apr 22, 2024
strantalis
approved these changes
Apr 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.0](service/v0.1.0...service/v0.2.0) (2024-04-26) ### Features * **policy:** move key access server registry under policy ([#655](#655)) ([7b63394](7b63394)) * **provisioning:** Keycloak provisioning from custom config ([#573](#573)) ([f9e9d72](f9e9d72)) * **sdk:** make enforcement of DPoP optional ([#617](#617)) ([028064c](028064c)) ### Bug Fixes * **core:** remove unused db argument ([#653](#653)) ([cfbd168](cfbd168)) * **db:** invalid uuid error message ([#633](#633)) ([c8f61aa](c8f61aa)) * **sdk:** this (`enforceDPoP`) flag needs to be flipped ([#649](#649)) ([dd65db1](dd65db1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: jakedoublev <[email protected]>
tech-guru42
added a commit
to tech-guru42/TDF
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.0](opentdf/platform@service/v0.1.0...service/v0.2.0) (2024-04-26) ### Features * **policy:** move key access server registry under policy ([#655](opentdf/platform#655)) ([7b63394](opentdf/platform@7b63394)) * **provisioning:** Keycloak provisioning from custom config ([#573](opentdf/platform#573)) ([f9e9d72](opentdf/platform@f9e9d72)) * **sdk:** make enforcement of DPoP optional ([#617](opentdf/platform#617)) ([028064c](opentdf/platform@028064c)) ### Bug Fixes * **core:** remove unused db argument ([#653](opentdf/platform#653)) ([cfbd168](opentdf/platform@cfbd168)) * **db:** invalid uuid error message ([#633](opentdf/platform#633)) ([c8f61aa](opentdf/platform@c8f61aa)) * **sdk:** this (`enforceDPoP`) flag needs to be flipped ([#649](opentdf/platform#649)) ([dd65db1](opentdf/platform@dd65db1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: jakedoublev <[email protected]>
passion-127
added a commit
to passion-127/TDF
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.0](opentdf/platform@service/v0.1.0...service/v0.2.0) (2024-04-26) ### Features * **policy:** move key access server registry under policy ([#655](opentdf/platform#655)) ([7b63394](opentdf/platform@7b63394)) * **provisioning:** Keycloak provisioning from custom config ([#573](opentdf/platform#573)) ([f9e9d72](opentdf/platform@f9e9d72)) * **sdk:** make enforcement of DPoP optional ([#617](opentdf/platform#617)) ([028064c](opentdf/platform@028064c)) ### Bug Fixes * **core:** remove unused db argument ([#653](opentdf/platform#653)) ([cfbd168](opentdf/platform@cfbd168)) * **db:** invalid uuid error message ([#633](opentdf/platform#633)) ([c8f61aa](opentdf/platform@c8f61aa)) * **sdk:** this (`enforceDPoP`) flag needs to be flipped ([#649](opentdf/platform#649)) ([dd65db1](opentdf/platform@dd65db1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: jakedoublev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.