fix(core): remove unused db argument (#653)

Author: jrschumacher

service/internal/auth/authn.go

@@ -17,7 +17,6 @@ import (
 	"github.com/lestrrat-go/jwx/v2/jwk"
 	"github.com/lestrrat-go/jwx/v2/jws"
 	"github.com/lestrrat-go/jwx/v2/jwt"
-	"github.com/opentdf/platform/service/internal/db"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/metadata"
@@ -70,7 +69,7 @@ type Authentication struct {
 }
 
 // Creates new authN which is used to verify tokens for a set of given issuers
-func NewAuthenticator(ctx context.Context, cfg Config, d *db.Client) (*Authentication, error) {
+func NewAuthenticator(ctx context.Context, cfg Config) (*Authentication, error) {
 	a := &Authentication{
 		enforceDPoP: cfg.EnforceDPoP,
 	}
@@ -106,9 +105,6 @@ func NewAuthenticator(ctx context.Context, cfg Config, d *db.Client) (*Authentic
 	casbinConfig := CasbinConfig{
 		PolicyConfig: cfg.Policy,
 	}
-	if d != nil && d.SqlDB != nil {
-		casbinConfig.DB = d.SqlDB
-	}
 	slog.Info("initializing casbin enforcer")
 	if a.enforcer, err = NewCasbinEnforcer(casbinConfig); err != nil {
 		return nil, fmt.Errorf("failed to initialize casbin enforcer: %w", err)

service/internal/auth/authn_test.go

@@ -149,8 +149,7 @@ func (s *AuthSuite) SetupTest() {
 				Audience:    "test",
 			},
 			PublicRoutes: []string{"/public", "/public2/*", "/public3/static", "/static/*", "/static/*/*"},
-		},
-		nil)
+		})
 
 	s.Require().NoError(err)
 
@@ -554,7 +553,7 @@ func (s *AuthSuite) Test_Allowing_Auth_With_No_DPoP() {
 	}
 	config := Config{}
 	config.AuthNConfig = authnConfig
-	auth, err := NewAuthenticator(context.Background(), config, nil)
+	auth, err := NewAuthenticator(context.Background(), config)
 
 	s.Require().NoError(err)
 

service/internal/auth/casbin.go

@@ -1,7 +1,6 @@
 package auth
 
 import (
-	"database/sql"
 	"fmt"
 	"strings"
 
@@ -133,7 +132,6 @@ type casbinSubject struct {
 
 type CasbinConfig struct {
 	PolicyConfig
-	DB *sql.DB
 }
 
 // newCasbinEnforcer creates a new casbin enforcer

service/internal/server/server.go

@@ -93,7 +93,6 @@ func NewOpenTDFServer(config Config, d *db.Client) (*OpenTDFServer, error) {
 		authN, err = auth.NewAuthenticator(
 			context.Background(),
 			config.Auth,
-			d,
 		)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create authentication interceptor: %w", err)