-
Notifications
You must be signed in to change notification settings - Fork 24
feat(policy): update fixtures, proto comments, and proto field names to reflect use of jq selector syntax within Conditions of Subject Sets #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethhealy
previously approved these changes
Apr 5, 2024
jakedoublev
commented
Apr 5, 2024
…and add functionality to unescape on SELECT query and hydration coming out of the DB
f284c4c to
3a4e863
Compare
ttschampel
approved these changes
Apr 8, 2024
alkalescent
pushed a commit
that referenced
this pull request
Apr 8, 2024
…to reflect use of jq selector syntax within Conditions of Subject Sets (#523) Caused by #477 ~~This will be followed by an immediate but separate PR with an integration test case for a complex jq expression with double quotes, which is currently having issues marshaling and unmarshaling from JSON.~~ Edit: Integration test has been added within this PR ([commit](986d346)). Includes migration to update any stored policy subject condition sets with the new corrected JSON/proto field. Related to #516
This was referenced Apr 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](protocol/go-v0.1.0...protocol/go/v0.1.0) (2024-04-22) ### Features * **attr value lookup by fqn:** adds GetAttributesByFqns rpc in attributes service [#243](#243) ([#250](#250)) ([b810d33](b810d33)) * **auth:** add authorization via casbin ([#417](#417)) ([292f2bd](292f2bd)) * **authorization service:** Gets the attributes from the in-memory service connection inside the GetDecisions request ([#273](#273)) ([ce57117](ce57117)) * **authorization:** entitlements ([#247](#247)) ([42c4f27](42c4f27)) * **core:** exposes new well-known configuration endpoint ([#299](#299)) ([d52cd21](d52cd21)) * **idp-add-on:** PLAT-3005 Add keycloak idp add on and idp add on protos ([#233](#233)) ([2365e61](2365e61)) * **kas:** authorization decisions ([#431](#431)) ([82e8895](82e8895)) * **PLAT-2950:** Update buf generated interface code for java ([#240](#240)) ([d7e2642](d7e2642)) * **policy object selectors:** adds initial selector protos, moves policy object type messages to top-level to avoid circular imports, and provides subject mappings in response to GetAttributeValuesByFqns ([#372](#372)) ([e9d9241](e9d9241)) * **policy subject mappings condition sets / migrations:** adds DB schema, fixes migrate down command, adds migrate up command, bumps goose ([#286](#286)) ([4d7a032](4d7a032)) * **policy:** adds support for match subject request to get entitlements without FQN scopes ([#347](#347)) ([63c34a5](63c34a5)) * **policy:** enhance and expand metadata and normalize API ([#314](#314)) ([9389f3b](9389f3b)) * **policy:** enhance subject mappings with subject condition sets ([#321](#321)) ([df692eb](df692eb)) * **policy:** list attrs by namespace ([#479](#479)) ([92d8f8c](92d8f8c)) * **policy:** list attrs by namespace name ([#487](#487)) ([04e723f](04e723f)) * **policy:** rework attribute value members ([#398](#398)) ([1cb7d0c](1cb7d0c)) * **policy:** support attribute value creation ([#454](#454)) ([432ee6b](432ee6b)) * **policy:** update fixtures, proto comments, and proto field names to reflect use of jq selector syntax within Conditions of Subject Sets ([#523](#523)) ([16f40f7](16f40f7)) ### Bug Fixes * **authorization:** remove access pdp internal AttributeInstance type and use policy proto generated struct types instead ([#485](#485)) ([8435f59](8435f59)) * **policy:** Adds policy package infix ([#280](#280)) ([57e8ef9](57e8ef9)) * **protos:** authorization service's ResourceAttribute message should map to updated platform policy schema ([#238](#238)) ([bf381dc](bf381dc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](service-v0.1.0...service/v0.1.0) (2024-04-22) ### ⚠ BREAKING CHANGES * Singular platform/service ([#511](#511)) ### Features * ability to add public routes that bypass authn middleware ([#601](#601)) ([7c65308](7c65308)) * ability to set config key or config file from root cmd ([#502](#502)) ([56a0131](56a0131)) * allow --insecure in provision keycloak cmd ([#629](#629)) ([a672325](a672325)) * **kas:** support HSM and standard crypto ([#497](#497)) ([f0cbe03](f0cbe03)) * **opa:** Adding jq OPA builtin for selection ([#527](#527)) ([d4ab17a](d4ab17a)) * **policy:** add `created_at` and `updated_at` timestamps to metadata ([#538](#538)) ([e812563](e812563)) * **policy:** update fixtures, proto comments, and proto field names to reflect use of jq selector syntax within Conditions of Subject Sets ([#523](#523)) ([16f40f7](16f40f7)) * **sdk:** don't require `client_id` in the auth token ([#544](#544)) ([a1e70f9](a1e70f9)) * **sdk:** normalize token exchange ([#546](#546)) ([9059dff](9059dff)) ### Bug Fixes * **authorization:** Hierarchy working in GetDecisions ([#519](#519)) ([2856485](2856485)) * **core:** allow org-admin casbin role to call KAS rewrap endpoint ([#579](#579)) ([a64c62a](a64c62a)) * **core:** fix panic on nil pointer dereference by passing KAS the SDK instance on registration ([#574](#574)) ([327bfca](327bfca)) * **core:** fixes fixtures provisioning after filepath change with repo restructuring ([#521](#521)) ([f128e9f](f128e9f)) * load extraprops for a service config with remainder values ([#524](#524)) ([d3d72dc](d3d72dc)) * **PLAT-3069:** opentdf/platform, gRPC: Namespace with existed attribute(s) can be deactivated w/o any prompts ([#489](#489)) ([e5a3324](e5a3324)) * **policy:** remove hardcoded schema in goose migration 20240405000000 ([#596](#596)) ([36c3b16](36c3b16)) * **policy:** return `created_at` and `updated_at` timestamps in CREATE metadata ([#557](#557)) ([fcaaeea](fcaaeea)) * resolves issues auth policy configuration ([#498](#498)) ([08e67cf](08e67cf)) * **service:** go.mod version fix sync ([#604](#604)) ([6323efd](6323efd)) * url encode db password field to handle special characters ([#624](#624)) ([5069f9d](5069f9d)) ### Code Refactoring * Singular platform/service ([#511](#511)) ([40c8b97](40c8b97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42
added a commit
to tech-guru42/TDF
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](opentdf/platform@protocol/go-v0.1.0...protocol/go/v0.1.0) (2024-04-22) ### Features * **attr value lookup by fqn:** adds GetAttributesByFqns rpc in attributes service [#243](opentdf/platform#243) ([#250](opentdf/platform#250)) ([b810d33](opentdf/platform@b810d33)) * **auth:** add authorization via casbin ([#417](opentdf/platform#417)) ([292f2bd](opentdf/platform@292f2bd)) * **authorization service:** Gets the attributes from the in-memory service connection inside the GetDecisions request ([#273](opentdf/platform#273)) ([ce57117](opentdf/platform@ce57117)) * **authorization:** entitlements ([#247](opentdf/platform#247)) ([42c4f27](opentdf/platform@42c4f27)) * **core:** exposes new well-known configuration endpoint ([#299](opentdf/platform#299)) ([d52cd21](opentdf/platform@d52cd21)) * **idp-add-on:** PLAT-3005 Add keycloak idp add on and idp add on protos ([#233](opentdf/platform#233)) ([2365e61](opentdf/platform@2365e61)) * **kas:** authorization decisions ([#431](opentdf/platform#431)) ([82e8895](opentdf/platform@82e8895)) * **PLAT-2950:** Update buf generated interface code for java ([#240](opentdf/platform#240)) ([d7e2642](opentdf/platform@d7e2642)) * **policy object selectors:** adds initial selector protos, moves policy object type messages to top-level to avoid circular imports, and provides subject mappings in response to GetAttributeValuesByFqns ([#372](opentdf/platform#372)) ([e9d9241](opentdf/platform@e9d9241)) * **policy subject mappings condition sets / migrations:** adds DB schema, fixes migrate down command, adds migrate up command, bumps goose ([#286](opentdf/platform#286)) ([4d7a032](opentdf/platform@4d7a032)) * **policy:** adds support for match subject request to get entitlements without FQN scopes ([#347](opentdf/platform#347)) ([63c34a5](opentdf/platform@63c34a5)) * **policy:** enhance and expand metadata and normalize API ([#314](opentdf/platform#314)) ([9389f3b](opentdf/platform@9389f3b)) * **policy:** enhance subject mappings with subject condition sets ([#321](opentdf/platform#321)) ([df692eb](opentdf/platform@df692eb)) * **policy:** list attrs by namespace ([#479](opentdf/platform#479)) ([92d8f8c](opentdf/platform@92d8f8c)) * **policy:** list attrs by namespace name ([#487](opentdf/platform#487)) ([04e723f](opentdf/platform@04e723f)) * **policy:** rework attribute value members ([#398](opentdf/platform#398)) ([1cb7d0c](opentdf/platform@1cb7d0c)) * **policy:** support attribute value creation ([#454](opentdf/platform#454)) ([432ee6b](opentdf/platform@432ee6b)) * **policy:** update fixtures, proto comments, and proto field names to reflect use of jq selector syntax within Conditions of Subject Sets ([#523](opentdf/platform#523)) ([16f40f7](opentdf/platform@16f40f7)) ### Bug Fixes * **authorization:** remove access pdp internal AttributeInstance type and use policy proto generated struct types instead ([#485](opentdf/platform#485)) ([8435f59](opentdf/platform@8435f59)) * **policy:** Adds policy package infix ([#280](opentdf/platform#280)) ([57e8ef9](opentdf/platform@57e8ef9)) * **protos:** authorization service's ResourceAttribute message should map to updated platform policy schema ([#238](opentdf/platform#238)) ([bf381dc](opentdf/platform@bf381dc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42
added a commit
to tech-guru42/TDF
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](opentdf/platform@service-v0.1.0...service/v0.1.0) (2024-04-22) ### ⚠ BREAKING CHANGES * Singular platform/service ([#511](opentdf/platform#511)) ### Features * ability to add public routes that bypass authn middleware ([#601](opentdf/platform#601)) ([7c65308](opentdf/platform@7c65308)) * ability to set config key or config file from root cmd ([#502](opentdf/platform#502)) ([56a0131](opentdf/platform@56a0131)) * allow --insecure in provision keycloak cmd ([#629](opentdf/platform#629)) ([a672325](opentdf/platform@a672325)) * **kas:** support HSM and standard crypto ([#497](opentdf/platform#497)) ([f0cbe03](opentdf/platform@f0cbe03)) * **opa:** Adding jq OPA builtin for selection ([#527](opentdf/platform#527)) ([d4ab17a](opentdf/platform@d4ab17a)) * **policy:** add `created_at` and `updated_at` timestamps to metadata ([#538](opentdf/platform#538)) ([e812563](opentdf/platform@e812563)) * **policy:** update fixtures, proto comments, and proto field names to reflect use of jq selector syntax within Conditions of Subject Sets ([#523](opentdf/platform#523)) ([16f40f7](opentdf/platform@16f40f7)) * **sdk:** don't require `client_id` in the auth token ([#544](opentdf/platform#544)) ([a1e70f9](opentdf/platform@a1e70f9)) * **sdk:** normalize token exchange ([#546](opentdf/platform#546)) ([9059dff](opentdf/platform@9059dff)) ### Bug Fixes * **authorization:** Hierarchy working in GetDecisions ([#519](opentdf/platform#519)) ([2856485](opentdf/platform@2856485)) * **core:** allow org-admin casbin role to call KAS rewrap endpoint ([#579](opentdf/platform#579)) ([a64c62a](opentdf/platform@a64c62a)) * **core:** fix panic on nil pointer dereference by passing KAS the SDK instance on registration ([#574](opentdf/platform#574)) ([327bfca](opentdf/platform@327bfca)) * **core:** fixes fixtures provisioning after filepath change with repo restructuring ([#521](opentdf/platform#521)) ([f128e9f](opentdf/platform@f128e9f)) * load extraprops for a service config with remainder values ([#524](opentdf/platform#524)) ([d3d72dc](opentdf/platform@d3d72dc)) * **PLAT-3069:** opentdf/platform, gRPC: Namespace with existed attribute(s) can be deactivated w/o any prompts ([#489](opentdf/platform#489)) ([e5a3324](opentdf/platform@e5a3324)) * **policy:** remove hardcoded schema in goose migration 20240405000000 ([#596](opentdf/platform#596)) ([36c3b16](opentdf/platform@36c3b16)) * **policy:** return `created_at` and `updated_at` timestamps in CREATE metadata ([#557](opentdf/platform#557)) ([fcaaeea](opentdf/platform@fcaaeea)) * resolves issues auth policy configuration ([#498](opentdf/platform#498)) ([08e67cf](opentdf/platform@08e67cf)) * **service:** go.mod version fix sync ([#604](opentdf/platform#604)) ([6323efd](opentdf/platform@6323efd)) * url encode db password field to handle special characters ([#624](opentdf/platform#624)) ([5069f9d](opentdf/platform@5069f9d)) ### Code Refactoring * Singular platform/service ([#511](opentdf/platform#511)) ([40c8b97](opentdf/platform@40c8b97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127
added a commit
to passion-127/TDF
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](opentdf/platform@protocol/go-v0.1.0...protocol/go/v0.1.0) (2024-04-22) ### Features * **attr value lookup by fqn:** adds GetAttributesByFqns rpc in attributes service [#243](opentdf/platform#243) ([#250](opentdf/platform#250)) ([b810d33](opentdf/platform@b810d33)) * **auth:** add authorization via casbin ([#417](opentdf/platform#417)) ([292f2bd](opentdf/platform@292f2bd)) * **authorization service:** Gets the attributes from the in-memory service connection inside the GetDecisions request ([#273](opentdf/platform#273)) ([ce57117](opentdf/platform@ce57117)) * **authorization:** entitlements ([#247](opentdf/platform#247)) ([42c4f27](opentdf/platform@42c4f27)) * **core:** exposes new well-known configuration endpoint ([#299](opentdf/platform#299)) ([d52cd21](opentdf/platform@d52cd21)) * **idp-add-on:** PLAT-3005 Add keycloak idp add on and idp add on protos ([#233](opentdf/platform#233)) ([2365e61](opentdf/platform@2365e61)) * **kas:** authorization decisions ([#431](opentdf/platform#431)) ([82e8895](opentdf/platform@82e8895)) * **PLAT-2950:** Update buf generated interface code for java ([#240](opentdf/platform#240)) ([d7e2642](opentdf/platform@d7e2642)) * **policy object selectors:** adds initial selector protos, moves policy object type messages to top-level to avoid circular imports, and provides subject mappings in response to GetAttributeValuesByFqns ([#372](opentdf/platform#372)) ([e9d9241](opentdf/platform@e9d9241)) * **policy subject mappings condition sets / migrations:** adds DB schema, fixes migrate down command, adds migrate up command, bumps goose ([#286](opentdf/platform#286)) ([4d7a032](opentdf/platform@4d7a032)) * **policy:** adds support for match subject request to get entitlements without FQN scopes ([#347](opentdf/platform#347)) ([63c34a5](opentdf/platform@63c34a5)) * **policy:** enhance and expand metadata and normalize API ([#314](opentdf/platform#314)) ([9389f3b](opentdf/platform@9389f3b)) * **policy:** enhance subject mappings with subject condition sets ([#321](opentdf/platform#321)) ([df692eb](opentdf/platform@df692eb)) * **policy:** list attrs by namespace ([#479](opentdf/platform#479)) ([92d8f8c](opentdf/platform@92d8f8c)) * **policy:** list attrs by namespace name ([#487](opentdf/platform#487)) ([04e723f](opentdf/platform@04e723f)) * **policy:** rework attribute value members ([#398](opentdf/platform#398)) ([1cb7d0c](opentdf/platform@1cb7d0c)) * **policy:** support attribute value creation ([#454](opentdf/platform#454)) ([432ee6b](opentdf/platform@432ee6b)) * **policy:** update fixtures, proto comments, and proto field names to reflect use of jq selector syntax within Conditions of Subject Sets ([#523](opentdf/platform#523)) ([16f40f7](opentdf/platform@16f40f7)) ### Bug Fixes * **authorization:** remove access pdp internal AttributeInstance type and use policy proto generated struct types instead ([#485](opentdf/platform#485)) ([8435f59](opentdf/platform@8435f59)) * **policy:** Adds policy package infix ([#280](opentdf/platform#280)) ([57e8ef9](opentdf/platform@57e8ef9)) * **protos:** authorization service's ResourceAttribute message should map to updated platform policy schema ([#238](opentdf/platform#238)) ([bf381dc](opentdf/platform@bf381dc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127
added a commit
to passion-127/TDF
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](opentdf/platform@service-v0.1.0...service/v0.1.0) (2024-04-22) ### ⚠ BREAKING CHANGES * Singular platform/service ([#511](opentdf/platform#511)) ### Features * ability to add public routes that bypass authn middleware ([#601](opentdf/platform#601)) ([7c65308](opentdf/platform@7c65308)) * ability to set config key or config file from root cmd ([#502](opentdf/platform#502)) ([56a0131](opentdf/platform@56a0131)) * allow --insecure in provision keycloak cmd ([#629](opentdf/platform#629)) ([a672325](opentdf/platform@a672325)) * **kas:** support HSM and standard crypto ([#497](opentdf/platform#497)) ([f0cbe03](opentdf/platform@f0cbe03)) * **opa:** Adding jq OPA builtin for selection ([#527](opentdf/platform#527)) ([d4ab17a](opentdf/platform@d4ab17a)) * **policy:** add `created_at` and `updated_at` timestamps to metadata ([#538](opentdf/platform#538)) ([e812563](opentdf/platform@e812563)) * **policy:** update fixtures, proto comments, and proto field names to reflect use of jq selector syntax within Conditions of Subject Sets ([#523](opentdf/platform#523)) ([16f40f7](opentdf/platform@16f40f7)) * **sdk:** don't require `client_id` in the auth token ([#544](opentdf/platform#544)) ([a1e70f9](opentdf/platform@a1e70f9)) * **sdk:** normalize token exchange ([#546](opentdf/platform#546)) ([9059dff](opentdf/platform@9059dff)) ### Bug Fixes * **authorization:** Hierarchy working in GetDecisions ([#519](opentdf/platform#519)) ([2856485](opentdf/platform@2856485)) * **core:** allow org-admin casbin role to call KAS rewrap endpoint ([#579](opentdf/platform#579)) ([a64c62a](opentdf/platform@a64c62a)) * **core:** fix panic on nil pointer dereference by passing KAS the SDK instance on registration ([#574](opentdf/platform#574)) ([327bfca](opentdf/platform@327bfca)) * **core:** fixes fixtures provisioning after filepath change with repo restructuring ([#521](opentdf/platform#521)) ([f128e9f](opentdf/platform@f128e9f)) * load extraprops for a service config with remainder values ([#524](opentdf/platform#524)) ([d3d72dc](opentdf/platform@d3d72dc)) * **PLAT-3069:** opentdf/platform, gRPC: Namespace with existed attribute(s) can be deactivated w/o any prompts ([#489](opentdf/platform#489)) ([e5a3324](opentdf/platform@e5a3324)) * **policy:** remove hardcoded schema in goose migration 20240405000000 ([#596](opentdf/platform#596)) ([36c3b16](opentdf/platform@36c3b16)) * **policy:** return `created_at` and `updated_at` timestamps in CREATE metadata ([#557](opentdf/platform#557)) ([fcaaeea](opentdf/platform@fcaaeea)) * resolves issues auth policy configuration ([#498](opentdf/platform#498)) ([08e67cf](opentdf/platform@08e67cf)) * **service:** go.mod version fix sync ([#604](opentdf/platform#604)) ([6323efd](opentdf/platform@6323efd)) * url encode db password field to handle special characters ([#624](opentdf/platform#624)) ([5069f9d](opentdf/platform@5069f9d)) ### Code Refactoring * Singular platform/service ([#511](opentdf/platform#511)) ([40c8b97](opentdf/platform@40c8b97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #477
This will be followed by an immediate but separate PR with an integration test case for a complex jq expression with double quotes, which is currently having issues marshaling and unmarshaling from JSON.Edit: Integration test has been added within this PR (commit).Includes migration to update any stored policy subject condition sets with the new corrected JSON/proto field.
Related to #516