Skip to content

Commit 8435f59

Browse files
fix(authorization): remove access pdp internal AttributeInstance type and use policy proto generated struct types instead (#485)
1. removes `AttributeInstance` type 2. DRY improvements to tests in pdp_test.go 3. adds tests for existing and new helper functions (grouping, FQN relations, etc) 4. fixes commented structure vs real structure of `EntityEntitlements` proto and clarifies field name Addresses #469 Original PR #471 and author @jakedoublev
1 parent 92d8f8c commit 8435f59

File tree

10 files changed

+1526
-1592
lines changed

10 files changed

+1526
-1592
lines changed

docs/grpc/index.html

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/openapi/authorization/authorization.swagger.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/cmd/authorization.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func authorizationExamples(examplesConfig *ExampleConfig) error {
5555
Actions: actions,
5656
EntityChains: entityChains,
5757
ResourceAttributes: []*authorization.ResourceAttribute{
58-
{AttributeFqns: []string{tradeSecretAttributeValueFqn, openAttributeValueFqn}},
58+
{AttributeValueFqns: []string{tradeSecretAttributeValueFqn, openAttributeValueFqn}},
5959
},
6060
})
6161

internal/access/attributeinstance.go

Lines changed: 0 additions & 97 deletions
This file was deleted.

0 commit comments

Comments
 (0)