enhance "incompatible source" warnings for changesets#11334
Merged
Conversation
tyrasd
changed the title
hlfan
reviewed
Aug 22, 2025
tyrasd
force-pushed
the
issue-8400
branch
4 times, most recently
from
e31d13f to
070ab8b
Compare
* not only warn on keyword "google", but: * use same list as is used by the "incompatible source" validator for map features * also warn when an incompatible source is mentioned in the "sources" field / changeset tag * include number of invalid sources in uploaded changeset tags in 'warnings:incompatible_source', fixes #8400 * also show multiple incompatible sources on features that match more than one rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warnings:incompatible_sourcechangeset tag, fixes changeset tag warnings:incompatible_source #8400example changeset
as this changes and introduces strings to translate, this should wait for the v2.37, so open todo: